Bug 4644 - UpdatingDisplayValue should signal when the expression value changes
Summary: UpdatingDisplayValue should signal when the expression value changes
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Adam Jocksch
URL:
Keywords:
Depends on:
Blocks: 4547
  Show dependency tree / graph
 
Reported: 2007-06-14 17:35 UTC by Adam Jocksch
Modified: 2007-06-18 19:29 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Jocksch 2007-06-14 17:35:30 UTC 
In addition to signalling whenever the task is stopped, UpdatingDisplayValue
should signal whenever the value of the expression changes. This is more useful
as a lower-overhead and coarser-grained message.
Comment 1 Adam Jocksch 2007-06-18 19:29:27 UTC 
This now works, as confirmed by frysk.rt.TestUpdatingDisplayValue.

ChangeLog:
2007-06-18  Adam Jocksch <ajocksch@redhat.com>

	* DisplayValueObserver.java (updateValueChanged): Added.
	* TestDisplayValue.java: Added comments to individual tests.
	* TestUpdatingDisplayValue.java (testUpdateTaskStopped): Changed
	lines at which breakpoints were being added.
	(testUpdateValueChanged): Added, confirms bz# 4644 as fixed.
	(DisplayObserver): Changed to reflect above change to 
	DisplayValueObserver.
	* UpdatingDisplayValue.java (oldValue): Added, tracks previous value
	of the expression.
	(refresh): Now compares the current byte array to the previous one
	and signals the observers if the value has changed.
	(notifyObserversValueChanged): Added.
	(arrayChanged): Added.
	(LockObserver): Now correctly recognizes stopping/continuing events
	from the SteppingEngine.
	* Location.java: Made public so we can access the internal ByteBuffer.