Bug 4173 - Variable watch does not work for multiple threads
Summary: Variable watch does not work for multiple threads
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Mike Cvet
URL:
Keywords:
Depends on:
Blocks: 1633 3663
  Show dependency tree / graph
 
Reported: 2007-03-08 19:38 UTC by Mike Cvet
Modified: 2007-03-08 20:42 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Cvet 2007-03-08 19:38:38 UTC 
and instead works for only one of the active threads in the sourceWindow. 
Should work for all innermost frames of all threads.
Comment 1 Mike Cvet 2007-03-08 20:42:28 UTC 
frysk-core/frysk/cli:
2007-03-08  Mike Cvet  <mcvet@redhat.com>

	* hpd/Symtab.java (task): Not used, removed.
	(exprSymTab): Changed to an array. Will contain an ExprSymTab for
	each thread of a process. Fixes #4173.
	(SymTab): Changed parameter 'pid_p' to 'tid_p'. Initializes the new
	ExprSymTab array.
	(print): Moved TmpSymTab initialization inside if statement.
	Added a while loop to check through all elements of the ExprSymTab
	array for a variable. Fixes #4173.
	(setFrames): Added. Static method to be called after a step; updating
	the ExprSymTab array with fresh StackFrame values.

frysk-gui/frysk/gui/srcwin:
2007-03-08  Mike cvet  <mcvet@redhat.com>

	* SourceWindow.java (generateProcStackTrace): Deleted commented-out
	dead code. Makes a call to SymTab.setFrames after StackFrame
	completion.
	* SourceBuffer.java (getVariable): Removed SymTab initialization
	code, and instead this now calls SymTab.print() directly, as the
	information was updated after the last step.