Bug 3723 - Create dummy (empty) StackFrames if stacktrace fails
Summary: Create dummy (empty) StackFrames if stacktrace fails
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Mike Cvet
URL:
Keywords:
Depends on:
Blocks: 1633 2936
  Show dependency tree / graph
 
Reported: 2006-12-14 16:15 UTC by Mike Cvet
Modified: 2006-12-14 20:32 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Cvet 2006-12-14 16:15:22 UTC 
That way, nobody has to worry about null StackFrames in the SourceWindow.
Comment 1 Mike Cvet 2006-12-14 20:32:13 UTC 
frysk-core/frysk/rt:
2006-12-14  Mike Cvet  <mcvet@redhat.com>

	* StackFactory.java (createStackFrame): Catch Exceptions coming out of
	StackTraceCreator, and return an empty StackFrame instead of null. Fixes
	#3723.
	* StackFrame.java (StackFrame): New constructor, taking a Task. Used to 
	create an empty StackFrame.
	(getMethodName): If the method name is null, return an empty String 
	instead.

frysk-gui/frysk/gui/srcwin:
2006-12-14  Mike Cvet  <mcvet@redhat.com>

	* CurrentStackView.java (buildTree): Won't get null StackFrames
	anymore, removed redundancies. Compare Tasks using their TID.
	* SourceBuffer.java (highlightLine): Return before doing anything
	if the scope of this Buffer has no source. If the incoming StackFrame
	has no debuginfo, try and find a frame in the stack that does.
	* SourceWindow.java (populateStackBrowser): Cleaned up, removed
	redundant checks. Fixes #3723.