Bug 3710 - Improve source code parsing speed by only parsing souce files as-needed
Summary: Improve source code parsing speed by only parsing souce files as-needed
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Rick Moseley
URL:
Keywords:
Depends on:
Blocks: 1633 3392
  Show dependency tree / graph
 
Reported: 2006-12-12 21:30 UTC by Rick Moseley
Modified: 2007-02-16 14:09 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Moseley 2006-12-12 21:30:08 UTC 
Right now, all source files listed in the executable header are parsed at the
very beginning.  The way Adam originally envisioned it is that we should only
parse source files as we need them.  That is, parse the source file needed to
show the current stack frame and stop.  If any other stack frames are clicked
on, parse those source files and add them to the DOM as-needed.
Comment 1 Rick Moseley 2007-02-16 14:09:26 UTC 
This has now been fixed in cvs head.  Source code is now only added to the DOM
on an as-needed basis, that is, as it is stepped into or a stack frame is
clicked on that requires a source file not currently in the DOM.

* DOMCommon.java: New.
* DomImage.java: Add addSource method to call parser when
  adding source element to DOM.
* TestParser.java: Call methods in DOMCommon instead of
  DOMFactory.
* DOMFactory.java: Pull static methods out and put in DOMCommon.
* fparser.java: Use methods from DOMCommon instead of
  DOMFactory.
* SourceWindow.java (generateProcStackTrace): Add logic to only
  parse source file when necessary.