Bug 3647 - MapsBuilder does not expose Shared flag
Summary: MapsBuilder does not expose Shared flag
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Andrew Cagney
URL:
Keywords:
Depends on:
Blocks: 2243
  Show dependency tree / graph
 
Reported: 2006-12-04 20:57 UTC by Phil Muldoon
Modified: 2007-02-02 18:11 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Muldoon 2006-12-04 20:57:39 UTC 
The private flag that is now exposed can be 

empty|private|shared

Need to expose a boolean through the the Builder than exposes the shared flag is
neither private or unset is true.
Comment 1 Phil Muldoon 2006-12-08 05:11:05 UTC 
2006-12-07  Phil Muldoon  <pmuldoon@redhat.com>
	
	* TestMaps.java: Add permShared flag
	* MapsBuilder.java: Ditto.
	* cni/MapsBuilder.cxx (construct): Add
	permShared check and flag.
Comment 2 Phil Muldoon 2006-12-08 15:50:54 UTC 
The fix is unsatisfactory given that the flag can be unset|shared|private
Comment 3 Andrew Cagney 2007-02-02 18:11:05 UTC 
Private and shared are mutually exclusive, this removes private leaving shared.

Index: frysk-core/frysk/rt/ChangeLog
2007-02-02  Andrew Cagney  <cagney@redhat.com>

        * TestStackBacktrace.java: Update to match
        frysk.sys.proc.MapsBuilder change, permPrivate removed.

Index: frysk-core/frysk/util/ChangeLog
2007-02-02  Andrew Cagney  <cagney@redhat.com>

        * CoredumpAction.java: Update to match frysk.sys.proc.MapsBuilder
        change, permPrivate removed.
        * TestFCore.java: Ditto.

Index: frysk-imports/frysk/sys/proc/ChangeLog
2007-02-02  Andrew Cagney  <cagney@redhat.com>

        * MapsBuilder.java (buildMap): Delete parameter permPrivate,
        rename permShared to shared.
        * TestMaps.java: Update.

Doing it as an ENUM is a nice to have once there's java 1.5.