Bug 32504 - move mapped_index_base to read-gdb-index.c
Summary: move mapped_index_base to read-gdb-index.c
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: symtab (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: 17.1
Assignee: Tom Tromey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-27 22:39 UTC by Tom Tromey
Modified: 2025-01-17 15:59 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:
Project(s) to access:
ssh public key:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Tromey 2024-12-27 22:39:52 UTC 
mapped_index_base is no longer needed by the .debug_names
reader, and so it could be moved into read-gdb-index.c.
The main benefit is that this would shrink read.c a little.
Also if/when we remove the index reader, this deletion would
be simpler.
Comment 2 Sourceware Commits 2025-01-17 15:58:24 UTC 
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=400f304b4fad79a952d959a42a719ac90ab3d50d

commit 400f304b4fad79a952d959a42a719ac90ab3d50d
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Jan 15 16:18:15 2025 -0700

    Remove mapped_index_base
    
    The base class mapped_index_base is no longer needed.  Previously it
    was used by both the .gdb_index and .debug_names readers, but the
    latter now uses the cooked index instead.
    
    This patch removes mapped_index_base, merging it into
    mapped_gdb_index.  Supporting code that is specific to .gdb_index is
    also moved into read-gdb-index.c.  This shrinks dwarf2/read.c a bit,
    which is nice.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32504
    Approved-By: Andrew Burgess <aburgess@redhat.com>
Comment 3 Tom Tromey 2025-01-17 15:59:40 UTC 
Fixed.