Bug 1431 - delete LinuxTask.pid
Summary: delete LinuxTask.pid
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P1 normal
Target Milestone: ---
Assignee: Andrew Cagney
URL:
Keywords:
Depends on:
Blocks: 1593
  Show dependency tree / graph
 
Reported: 2005-10-06 20:01 UTC by Andrew Cagney
Modified: 2005-10-29 16:00 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2005-10-06 20:01:08 UTC 
LinuxTask.pid is redundant (and dangerous), code can instead extract the task id
from Task.id.

Dangerous?  It is only initialized after Task.Task has finished, and that is
after the task observers are called.
Comment 1 Andrew Cagney 2005-10-06 20:28:07 UTC 
2005-10-06  Andrew Cagney  <cagney@redhat.com>

        * Task.java: Replace getPid with getTid.  Make getTid, and
        getTaskId final.
        * LinuxTask.java: Delete "pid", "addMemoryAndRegisters", and
        "ptraceAttached".  Use getTid.
        * I386Linux.java, ProcState.java, LinuxProc.java: Update.

2005-10-06  Andrew Cagney  <cagney@redhat.com>

        * ThreadMenu.java, ProcDataModel.java, EventLogger.java: For
        tasks, use getTid instead of getPid.
Comment 2 Andrew Cagney 2005-10-06 20:28:24 UTC 
all deleted