Bug 11840 - Bad use of the autoconf cache for -fgnu89-inline
Summary: Bad use of the autoconf cache for -fgnu89-inline
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: libc (show other bugs)
Version: 2.11
: P2 normal
Target Milestone: ---
Assignee: Ulrich Drepper
URL:
Keywords:
: 6679 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-07-25 21:26 UTC by Lluís Batlle
Modified: 2014-06-30 17:31 UTC (History)
2 users (show)

See Also:
Host: mips64el-unknown-linux-gnu
Target: mips64el-unknown-linux-gnu
Build: mips64el-unknown-linux-gnu
Last reconfirmed:
fweimer: security-

Attachments
Fix (257 bytes, patch)
2010-07-25 21:28 UTC, Lluís Batlle 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lluís Batlle 2010-07-25 21:26:19 UTC 
(I think this affects any triplet)

The current implementation made the -fgnu89-inline had a double meaning (yes/no
or the compiler flag). In case of cache reusage of the variable containing the
compiler flag, it was considered as a "!= yes", and then nullified, ending in no
-fgnu89-inline flag used at the 'configure' step run from the glibc Makefile.

Here are the offending lines of code:
if test $libc_cv_gnu89_inline = yes; then
  libc_cv_gnu89_inline=-fgnu89-inline
else
  libc_cv_gnu89_inline=
fi

I will attach a patch.
Comment 1 Lluís Batlle 2010-07-25 21:28:12 UTC 
Created attachment 4884 [details]
Fix

I think this patch fixes the problem. This also patches 'configure'.
Comment 2 Roland McGrath 2010-07-26 19:47:25 UTC 
I fixed it differently, commit 1c7570f.
Comment 3 Andreas Jaeger 2012-04-06 19:44:35 UTC 
*** Bug 6679 has been marked as a duplicate of this bug. ***