*** Bug 10872 has been marked as a duplicate of this bug. ***

You'll have to provide a complete patch.

(In reply to comment #2)
> You'll have to provide a complete patch.

I could provide a patch, but there is a problem in specification. Neither "man 5 locale" nor "man date" specify the case of name. It is not clear whether it should be nominative, genitive or some another case.

For example, "date +'%d %B %Y'" produces "28 Февраль 2011" which looks incorrect (the first letter should be small, not capital, the form should be ). However, "date +'%B, %d-e'" produces "Февраль, 28-e" which looks correct. "date +'%B'" produces just months name "Февраль". I cannot say whether it correct or not without context.

The only clue could be `d_fmt' and `date_fmt' (but latter one is not described in "man 5 locale") values in locale definition file. It looks like date string produced with `date_fmt' should be correct, which means it Russian locale month name (%B) should be in genitive case. But it may break some existing programs which expect month name in nominative case...

The solution could be extending `mon' array. For example, it could contain 12, 24, or even more elements. Element #1 is name of January in nominative case, element #13 is name of January in genitive case, #25 is the name of January in some 3rd case, etc. `%B' is name of month in nominative case, `%1B' is the same as `%B', `%2B' is the name of months in genitive case, `%3B' is the name of months in the "3rd" case, etc.

Alternatively, it could be multidimensional array, so in construct `%nB' n selects the proper dimension.

Any thoughts on that?

(In reply to comment #3)
> (In reply to comment #2)
> > You'll have to provide a complete patch.
> 
> I could provide a patch, but there is a problem in specification. Neither "man
> 5 locale" nor "man date" specify the case of name. It is not clear whether it
> should be nominative, genitive or some another case.

If it is not specified, we should follow the language's rules. If it would be specified it has to be specified in accordance with the language's rules. So let me as a "native speaker" to suggest the solution.

Both months and weekdays should be in lower case. The correct form of date should be "28 февраля" (the genitive). If you add a weekday it is "понедельник, 28 февраля" (nominative for the weekday, genitive for month). A year, if necessary, should be after the day, optionally followed by the word "года" or the abbreviation "г.", line this "понедельник, 28 февраля 2011 года".

> The solution could be extending `mon' array. For example, it could contain 12,
> 24, or even more elements. Element #1 is name of January in nominative case,
> element #13 is name of January in genitive case, #25 is the name of January in
> some 3rd case, etc. `%B' is name of month in nominative case, `%1B' is the same
> as `%B', `%2B' is the name of months in genitive case, `%3B' is the name of
> months in the "3rd" case, etc.
> 
> Alternatively, it could be multidimensional array, so in construct `%nB' n
> selects the proper dimension.
> 
> Any thoughts on that?

I think one should definitely extend the "mon" array. However the better idea would be to put there not the cases (nominative, genitive etc) but the contexts (month's name "as-is", month's name "when used in a date" etc). The array could be extensible.

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > You'll have to provide a complete patch.
> > 
> > I could provide a patch, but there is a problem in specification. Neither "man
> > 5 locale" nor "man date" specify the case of name. It is not clear whether it
> > should be nominative, genitive or some another case.
> 
> If it is not specified, we should follow the language's rules.

And the language rules require to use nominative or genitive or some another case depending on context.

> If it would be
> specified it has to be specified in accordance with the language's rules. So
> let me as a "native speaker" to suggest the solution.
> 
> Both months and weekdays should be in lower case.

It depends.

> The correct form of date
> should be "28 февраля" (the genitive).

Yes, but "февраль, 28-е" is also correct.

> > The solution could be extending `mon' array. For example, it could contain 12,
> > 24, or even more elements. Element #1 is name of January in nominative case,
> > element #13 is name of January in genitive case, #25 is the name of January in
> > some 3rd case, etc. `%B' is name of month in nominative case, `%1B' is the same
> > as `%B', `%2B' is the name of months in genitive case, `%3B' is the name of
> > months in the "3rd" case, etc.
> > 
> > Alternatively, it could be multidimensional array, so in construct `%nB' n
> > selects the proper dimension.
> > 
> > Any thoughts on that?
> 
> I think one should definitely extend the "mon" array. However the better idea
> would be to put there not the cases (nominative, genitive etc) but the contexts
> (month's name "as-is", month's name "when used in a date" etc). The array could
> be extensible.

Yes, putting "mon" array in a single case (no matter whether it would be nominative, genitive or other case) cannot fix the issue, it would just fix some language forms and break other language forms.  To fix the issue, an extension is necessary.

The problem persists as of September 11, 2014, and concerns all Slavonic languages except Bulgarian and Macedonian (where declination is reduced). Among them are languages: Belarusian, Czech, Polish, Pomeranian/Kashubian, Russian, Rusyn, Slovak, Slovene, Serbo-Croatian (Croatian, Bosnian, Serbian, Montenegrin), Silesian, Upper and Lower Sorbian and Ukrainian. But not only in Slavonic, other languages using noun declinations are injured too. Finnish, for instance, is one extraordinary case that uses all three, nominative, genitive and partitive case month names.

The CLDR manages to fix the issue by introducing several data arrays to serve that specific purpose, both full and abbreviated versions (in case one needs those). In addition, it has correctly abbreviated weekday names. Unfortunately, I have no programming skills whatsoever to submit code that solves anything.

I'll be happy to provide a complete solution for this problem but some API design questions must be answered first.

Please note that CLDR mentions only "standalone" version of the month name which is probably always nominative, and "format" version which may be the same as "standalone" (e.g., in English) but may be genitive in some languages, it may also be another case in some other languages. For simplicity I will refer to these cases as nominative/genitive keeping in mind that CLDR refers to them as standalone/format. Also there may be languages which use other forms than nominative/genitive but I think there are probably always at most two forms since CLDR has decided to consider only two.


I. strftime() - http://linux.die.net/man/3/strftime

This function supports only one format which provides the full month name: %B. At the moment there is no way for this function to provide multiple forms of the full month name. Here are the API designs which would provide a full month name:

1. Do not change the API, implement an internal algorithm which would analyze a full format string and determine whether %B should format the month name in a nominative or genitive case. The simplest algorithm would check if %d or %e conversion specifiers are also present in the same format string, retrieve a genitive case if they are, nominative otherwise. More advanced version could check if the day and month conversion specifiers are adjacent, if they are separated with other conversion specifiers, with space/punctuation/other characters, if there are other letters concatenated with %B (which would mean that the caller already tries to provide a workaround for this bug), if the day/month order is correct (this is true only if day/month order is correct and month/day order is incorrect in all these languages).

Pros:
- once implemented correctly it will automagically fix all affected applications,
- even if the implementation will not be perfect for some languages the result will not be worse than the one currently existing: it will not break any currently correct application,
- if it turns out that this solution is completely wrong it will be easy to revert it and provide another one because we don't change the API.

Cons:
- may be difficult to implement,
- it is questionable if a perfect algorithm exists for all affected languages, even if we check it for all languages mentioned in the comment 6 there may be other languages which we don't know about and which also require the nominative/genitive case but use different rules,
- it is questionable how to handle the format strings which are incorrect from grammatical point of view: please note that strftime() API does not and should not say that there are illegal combination of the conversion specifiers.

2. Follow the specification already used in *BSD family (which also includes OS X and iOS): https://www.freebsd.org/cgi/man.cgi?query=strftime&sektion=3. They implement the %OB conversion specifier which retrieves the nominative case while %B specifier retrieves the genitive case (sic!)

Pros:
- full portability between glibc and *BSD,
- simple and deterministic implementation,
- full programmer's control on whether they want a nominative or genitive case,
- will automagically fix all dates using %B conversion specifiers and displaying the nominative case which is incorrect (full dates).

Cons:
- at the same time will break formatting of all dates using %B conversion specifiers where the nominative case is required and is correctly provided now, the application developer may not even be aware that the application became broken in some languages,
- therefore will require urgent intervention from some application developers,
- it will be difficult or even impossible to provide a backward compatible solution which would detect if the current runtime version of glibc requires %OB or %B for the month name in nominative case,
- one may question if the *BSD decision to retrieve a genitive case from %B is correct since it causes so much trouble.

3. Mimic the *BSD specification but implement it conversely: let %B retrieve the nominative case (as it currently does) and let the new %OB specifier retrieve the genitive case. See also: http://austingroupbugs.net/view.php?id=258 - this seems to has accepted this solution.

Pros:
- simple and deterministic implementation,
- full programmer's control on whether they want a nominative or genitive case,
- full backward compatibility,
- will not break any existing application.

Cons:
- portability with *BSD family will never be possible (format specifiers war),
- will require intervention from the application developers but it will not be urgent because it will apply only the cases where they use %B explicitly and this is already incorrect.

I would choose the first solution: not to change the API and try to provide a smart algorithm which would determine if the month name retrieved by %B should be nominative or genitive but I will listen to your opinion.


II. nl_langinfo() - http://linux.die.net/man/3/nl_langinfo

Although strftime() does not call nl_langinfo() directly both these functions use the same backend database. We will need the new constants to be defined in langinfo.h, for example ALTMON_{1-12} and their wide-character equivalents _NL_WALTMON_{1-12}. This means it will affect the API of nl_langinfo() by adding new valid argument values. Please note that I am talking in the context of https://bugzilla.gnome.org/show_bug.cgi?id=749206 and the implementation of g_date_time_printf() does call nl_langinfo() to retrieve the month names. I hope it is valid to add these new symbols after _NL_TIME_CODESET and name them ALTMON_{1-12} and _NL_WALTMON_{1-12}.

*** Bug 15606 has been marked as a duplicate of this bug. ***

Created attachment 8795 [details]
Proposed solution: alternative month names + smart algorithm

Good news: here is a working patch so please check, test, review, comment. It implements the solution with "%B" format specifier smartly expanding into a nominative or genitive (alternative) case depending on the current context. It hopefully does not break any existing solution and is fully backward compatible.

I have also provided the new locales for Polish, Russian and Ukrainian. I have checked this with CLDR data but feel free to drop the changes to these files if you think that other people should provide them. Please note that without the changed locales you would not see the effect of the code change. For Russian I have also changed the nominative month names to lowercase because some people requested it here. For Ukrainian I have removed the "alternative digits" hack and used the already provided genitive month names as the alternative names.

There are also some bad news:

1. The coreutils package (date, du) provides its own function fprintftime() which tries to bypass strftime() as much as possible and if it calls strftime() it retrieves only the month name so this patch will be unable to detect the "full date" context and provide the correct genitive form. This means that /usr/bin/date is not a good tool to test this patch. Perhaps it needs a patch similar to this one.

2. I had to introduce the new locale field day_month_order which will be available as nl_langinfo(_NL_DAY_MONTH_ORDER) and will determine if:
- only a day number before a month name forces the genitive month name (1),
- only a day number after a month name forces the genitive month name (3),
- both above orders force the genitive month name or this does not matter because the current language does not provide the alternative month names (2, default value when not specified).
Unfortunately, there is no universal rule for all languages. As stated in comment 5, Russian requires a genitive case if a day number is before the month name but a nominative case when reversed, both orders are correct. Other languages require the day number to be before the month name and do not allow to reverse them but we should not crash on grammatical errors, instead we should provide the closest result to the requirement. On the other hand, Lithuanian requires the month name to be before the day number and in the genitive case.

3. There are more languages which suffer from this bug. It is possible to retrieve the correct alternative month names from CLDR but I am not sure if this task should be a part of this bugfix or should be left to the native translators. I can provide more of them but providing all sounds like a horrible task.

4. I am not sure if you like the idea of "%B" to be smartly converted to the correct form of the month name. I will appreciate your feedback.

I think you need to send the patch to libc-alpha: https://sourceware.org/glibc/wiki/Contribution%20checklist

OK, sent: https://sourceware.org/ml/libc-alpha/2015-11/msg00594.html

Created attachment 8874 [details]
Proposed solution: support alternative month names

The previous patch could be considered too long and too difficult to review so here I split it into 7 parts which can be reviewed and accepted or rejected individually. This first part just adds the ALTMON_... constants.

I think this change is not questionable except the question whether these constants should be considered public or private. I suggest public.

Created attachment 8875 [details]
Add tests for the alternative month names

The only reason why this part has been split out into a separate patch is that the file tst-langinfo.c belongs to the localedata directory which has its own ChangeLog. Feel free to merge this patch with the previous one if you think that splitting it is bad idea.

Created attachment 8876 [details]
Proposed solution: support day month order

If we are going to implement a smart algorithm which determines whether "%B" should generate a nominative or genitive form we need also a new parameter which would determine if month should be genitive if it appears after a day, or before a day, or in both cases, or it does not matter. Feel free to merge this patch with the previous ones if you think this idea is OK. Feel free to reject this patch if you think that we should implement the "%OB" format specifier which would select the genitive case explicitly. See also comment 7 for more info.

Created attachment 8877 [details]
Proposed solution: smart algorithm choosing the nominative/genitive month name

This is the main part: the implementation of the smart algorithm in strftime() which would select the correct form of the month name for the "%B" format specifier. Note that this patch requires the previous ones, also it requires some NLS data from the following patches.

Created attachment 8878 [details]
Alternative month names NLS data (Polish)

Here are the genitive month names in Polish. Please note that this is my native language so I can guarantee the correctness. Feel free to use this patch only for local tests and reject it from the public repository if you don't trust me. However, please note that you need some NLS data with the alternative month names, otherwise you will not see any effect of the previous patches.

Created attachment 8879 [details]
Alternative month names NLS data (Russian)

Here are the genitive month names in Russian. The names are taken from CLDR database: http://st.unicode.org/cldr-apps/v#/ru/Gregorian/677bb4a72253df63 Also I have changed the nominative month names to lowercase as suggested in comment 0 and comment 4. Please note that you don't have to trust my knowledge of Russian, feel free to take this patch for your local tests only and reject from the public repository.

Created attachment 8880 [details]
Alternative month names NLS data (Ukrainian)

Here are the genitive month names in Ukrainian. The alternative month names had been already present so I have only changed the alt_digits label to alt_mon and removed all remains of the alt_digits hack. However, please note that you absolutely should not trust my knowledge of Ukrainian language. Feel free to use this patch for local tests only and reject it from the public repository.

This is the end of this series of patches. I'll appreciate your reviews.

(In reply to Rafal Luzynski from comment #7)

Thanks for a good analysis. However, I do not agree with your approach. 

> 1. Do not change the API, implement an internal algorithm which would
> analyze a full format string and determine whether %B should format the
> month name in a nominative or genitive case. 

This is a bad idea. You left programmer with no control over the result. For example: someone used format string like "This is %B" (I used English, but imagine another language, like Polish). Later his decided to include day number: "This is %B, today is day #%e." Since %B remains intact, programmer would assume the first part of the message remains intact too, but "artificial intelligence" may have own opinion and change case of month name depending on presence or absence of %e or whatever else. To me this is not acceptable.

Also, month name is not the only name in strftime. Look at %A — it's weekday name, which also has multiple forms/cases.

> 2. Follow the specification already used in *BSD family (which also includes
> OS X and iOS): https://www.freebsd.org/cgi/man.cgi?query=strftime&sektion=3.

This is not *BSD but POSIX:

http://pubs.opengroup.org/onlinepubs/009695399/functions/strftime.html

Description of strftime is not very clear what "alternative representation" and "alternative numeric symbols", but 

http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap07.html

adds some details. Both of %O and %E are not for changing case of month name.

Thus, I will propose an extension, dedicated for the problem. Current conversion specifier looks like:

"%" flag width [ modifier ] format

where "%" and "." are literal strings; flag — one of GNU flags: "-", "_", "0", "^" (see "info strftime"), width is a positive integer,  modifier is either "E" or "O", format — one of documented letters (a, b, B, c, C, ...).

Extension may utilize syntax of "precision" used in "printf", e. g.:

"%" flag width [ "." precision ] [ modifier ] format

in "strftime" precision = grammatic case number. In case of Russian "precision" would be in range 1..6 (since in Russian language nouns have 6 cases):

%.1B — month name in nominative case
%.2B — month name in accusative case
%.3B — month name in genitive case
%.4B — month name in dative case
%.5B — month name in instrumental case
%.6B — month name in prepositional case

Note that this is universal and can be used with week day names too:

%.1A, %.2A, etc.

"Precision" zero (".0") is used as default (when case is not specified) and as fallback (when specified "precision" is out of range for current locale).

"Precision" can be combined with width: %20.1B.

In such a case strftime maintains compatibility — behaviour of existing programs is not affected, but in new (versions of the) programs developers are free to specify case of names precisely.

(In reply to van.de.bugger from comment #19)

i think you might have missed some of the things Rafal said.  he is correct when he said BSD because they already have a format specifier for this: %OB.  POSIX does *not* support this today (see the linked POSIX bug report for more details) which leads us to the multiple choices he outlined in comment #7.

i don't think we should create yet another standard -- either we use what BSD already has, or we wait for POSIX to come up with one (and we go with his suggestion for automatic detection in the mean time since it doesn't break ABI).  if you want to extend the standard, please post to the POSIX lists.

On Wed, Jan 13, 2016 at 11:49:01PM +0000, vapier at gentoo dot org wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=10871
> 
> --- Comment #20 from Mike Frysinger <vapier at gentoo dot org> ---
> (In reply to van.de.bugger from comment #19)
> 
> i think you might have missed some of the things Rafal said.  he is correct
> when he said BSD because they already have a format specifier for this: %OB. 
> POSIX does *not* support this today (see the linked POSIX bug report for more
> details) which leads us to the multiple choices he outlined in comment #7.
> 
> i don't think we should create yet another standard -- either we use what BSD
> already has, or we wait for POSIX to come up with one (and we go with his
> suggestion for automatic detection in the mean time since it doesn't break
> ABI).  if you want to extend the standard, please post to the POSIX lists.

We follow ISO TR 30112, and not pOSIX in glibc. POSIX is quite outdated
wrt. i18n, and we cannot conform to POSIX's limited i18n capability.

But we can work on ISO TR 30112 which is under revision.

best regards
keld

(In reply to keld@keldix.com from comment #21)

running s/POSIX/ISO TR 30112/ on my comment doesn't change my point.  we should not be inventing our own new behavior here when there's long standing precedence.

On Thu, Jan 14, 2016 at 12:51:04PM +0000, vapier at gentoo dot org wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=10871
> 
> --- Comment #22 from Mike Frysinger <vapier at gentoo dot org> ---
> (In reply to keld@keldix.com from comment #21)
> 
> running s/POSIX/ISO TR 30112/ on my comment doesn't change my point.  we should
> not be inventing our own new behavior here when there's long standing
> precedence.

If the argument is that BSD already has this feature and we should follow their
specs, then I agree, and then I propose that we add this to 30112.

best regards
keld

(In reply to keld@keldix.com from comment #23)

please read comment #7 in full

(In reply to Mike Frysinger from comment #20)

> i think you might have missed some of the things Rafal said.  he is correct
> when he said BSD because they already have a format specifier for this: %OB.
> POSIX does *not* support this today (see the linked POSIX bug report for
> more details) which leads us to the multiple choices he outlined in comment
> #7.

1. I do not understand what do you mean by "POSIX does *not* support this today". POSIX is a standard, not an implementation, and O and E modifiers are described in the standard, see http://pubs.opengroup.org/onlinepubs/9699919799/functions/strftime.html 

2. By this description, O modifier is applicable to d, e, H, I, m, M, S, u, U, V, w, W, and y. OB is BSD-specific *extension* to POSIX.

3. %OB is not just BSD extension, it is also ugly hack which likely does not solve the problem. BSD offers only two cases for month name — %B and %OB, while in Russian language a noun has six cases, in Finnish — more than dozen. I am not a linguist and not aware about other languages, but it is obviously 2 cases cannot cover all the needs.

> i don't think we should create yet another standard -- either we use what
> BSD already has, or we wait for POSIX to come up with one (and we go with
> his suggestion for automatic detection in the mean time since it doesn't
> break ABI).  if you want to extend the standard, please post to the POSIX
> lists.

GNU libc have A LOT of extensions. It is not clear why you decided to stop adding extensions now.

Automatic detection does not break ABI, it breaks behavior of existing programs.

(In reply to keld@keldix.com from comment #21)
> We follow ISO TR 30112, and not pOSIX in glibc. POSIX is quite outdated
> wrt. i18n, and we cannot conform to POSIX's limited i18n capability.
> 
> But we can work on ISO TR 30112 which is under revision.

Sorry, I cannot afford to pay CHF 198 for ISO TR 30112 at ISO official site:

http://www.iso.org/iso/catalogue_detail.htm?csnumber=53232

If there is a publicly available revision of ISO TR 30112, please give me a link.

(In reply to van.de.bugger from comment #25)
> ...it is obviously 2 cases cannot cover all the needs.

Just an example:

Imagine a program, which (in entertainment purposes) reminds you famous events occurred in the same month, but (some|few|many) years ago. In English it will be probably "In January: ...", or, as strftime format: "In %B: ...".

Let us translate it to Russian: "В январе: ...". Note: month name in this example is neither in nominative case (январь), and not in genitive case (января), so neither "В %B: ..." nor "В %OB: ..." (proposed hack for genitive case) is suitable.

***

I do not insist on format proposed by me. My point is that new implementation should be able to produce any explicitly requested case of name (either month or weekday, it seems there are no other names in this area). If you do not like "precision" notation (borrowed from printf formats) — not a problem, just propose another.

On Sun, Jan 17, 2016 at 12:27:56AM +0000, van.de.bugger at gmail dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=10871
> 
> --- Comment #26 from van.de.bugger at gmail dot com ---
> (In reply to keld@keldix.com from comment #21)
> > We follow ISO TR 30112, and not pOSIX in glibc. POSIX is quite outdated
> > wrt. i18n, and we cannot conform to POSIX's limited i18n capability.
> > 
> > But we can work on ISO TR 30112 which is under revision.
> 
> Sorry, I cannot afford to pay CHF 198 for ISO TR 30112 at ISO official site:
> 
> http://www.iso.org/iso/catalogue_detail.htm?csnumber=53232
> 
> If there is a publicly available revision of ISO TR 30112, please give me a
> link.

http://www.open-std.org/JTC1/SC35/WG5/docs/30112d10.pdf
It should also be available from the SC35 documents site.

best regards
Keld

On Sun, Jan 17, 2016 at 12:22:38AM +0000, van.de.bugger at gmail dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=10871
> 
> --- Comment #25 from van.de.bugger at gmail dot com ---
> (In reply to Mike Frysinger from comment #20)
> 
> > i think you might have missed some of the things Rafal said.  he is correct
> > when he said BSD because they already have a format specifier for this: %OB.
> > POSIX does *not* support this today (see the linked POSIX bug report for
> > more details) which leads us to the multiple choices he outlined in comment
> > #7.
> 
> 1. I do not understand what do you mean by "POSIX does *not* support this
> today". POSIX is a standard, not an implementation, and O and E modifiers are
> described in the standard, see
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/strftime.html 
> 
> 2. By this description, O modifier is applicable to d, e, H, I, m, M, S, u, U,
> V, w, W, and y. OB is BSD-specific *extension* to POSIX.
> 
> 3. %OB is not just BSD extension, it is also ugly hack which likely does not
> solve the problem. BSD offers only two cases for month name ??? %B and %OB, while
> in Russian language a noun has six cases, in Finnish ??? more than dozen. I am
> not a linguist and not aware about other languages, but it is obviously 2 cases
> cannot cover all the needs.

Well, can we see what is the extent of the problem?
Russian, Polish, possibly all of the Slavian languages, Finnish,
Hungarian, Estonian?

One could also list all the grammatical cases,  number them and make a notation
in the format specifiers, but if the already implemented and specified
solution solves the problem for all languages with this problem, then
an extended solution could be overkill.

Best regards
Keld

In Finnish, all the month names end with "kuu" (moon) in the singular nominative, and you can form the genitive, partitive, or inessive by appending "n", "ta", or "ssa": tammikuu, tammikuun, tammikuuta, tammikuussa.  So I think we can largely cover text output just by localizing the strftime format string.

I think we'd write

tammikuu = January (nominative)
tammikuun 17. päivä = 17th day of January (genitive)
tammikuun 17. päivänä = on the 17th day of January (genitive)
tammikuun 17. päivänä 2016 = on the 17th day of January (genitive) 2016
17. tammikuuta = 17 January (partitive)
17. tammikuuta 2016 = 17 January (partitive) 2016
tammikuussa 2016 = in January (inessive) 2016

("1. tammikuu" seems like it would mean the January of the first year, as in, it snowed this much in the first January but not so much a year later.)

In plural forms though, the "kuu" ending often has to be modified: tammikuut (nominative), tammikuiden (genitive), tammikuita (partitive), tammikuissa (inessive). But I don't see these being used in dates.

There are forms like sunnuntaisin = on Sundays, talvisin = in wintertime. One could likewise say tammikuisin but this seems uncommon. Perhaps that form could be used in a web application where the user selects whether they want to be sent an invoice every January or every February.

(In reply to keld@keldix.com from comment #29)

Thanks for the link. I didn't read entire spec, but LC_TIME section looks very similar to POSIX. The only additions I found are first_weekday, first_workday, cal_direction, and timezone; the rest looks the same.

After looking through ISO/IEC 30112 and studying existing locale definitions in glibc, it is clear to me that O modifier is intended for writing numbers in traditional style. Some languages (Japanese, Persian, Oriya, Burmese to name a few) have traditional symbols for digits and numbers. So O modifier is applicable to numeric values only, and using %OB is a non-standard BSD hack.

BTW, I found a dirty hack in glibc: uk_UA locale has *month names* in genitive case in alt_digits table. Now they can get month name in genitive case by %Om, but applying modifier O to another format specifier (like %Od, %Of, %OH) is meaningless: %OI converts hour to a months name in genitive case... 

You see: users want to have properly formatted dates and ready to implement any dirty hacks for getting result.

> Well, can we see what is the extent of the problem?
> Russian, Polish, possibly all of the Slavian languages, Finnish,
> Hungarian, Estonian?

All the Slavic languages for sure. Sorry, I am not aware about other languages.

> One could also list all the grammatical cases,  number them and make a
> notation
> in the format specifiers, but if the already implemented and specified
> solution solves the problem for all languages with this problem, then
> an extended solution could be overkill.

I already wrote that two cases (%B and %OB) does not solve the problem in general. 

However, I understand that two cases (nominative and genitive) cover the great majority of use cases (for Russian language at least), and I know why: (1) all the demanding applications have implemented (and had to implement) date/time formatting routines in-house due to lack of support in standard libraries; (2) fixing standard libraries takes ages: you see, this issue was open 6 years ago, but problem is not yet solved.

(In reply to van.de.bugger from comment #25)
> 3. %OB is not just BSD extension, it is also ugly hack which likely does not
> solve the problem. BSD offers only two cases for month name — %B and %OB,
> while in Russian language a noun has six cases, in Finnish — more than
> dozen. I am not a linguist and not aware about other languages, but it is
> obviously 2 cases cannot cover all the needs.
> 

I don't think glibc is intended to be used to construct natural sentences, in which case we would need support for every single case in every single language. I don't think that's realistic or needed.

Instead, there are two applications: to show time and date, and to show a calendar. Using just standalone and format versions of the month names (or nominative and genitive) covers both uses.

Extending it would amount to overengineering a solution to a non-existing problem, while Rafal's proposition elegantly resolves a real-world, severe problem.

(In reply to Piotr Drąg from comment #32)
> Instead, there are two applications: to show time and date, and to show a
> calendar. Using just standalone and format versions of the month names (or
> nominative and genitive) covers both uses.

In such a case we would need just two functions: show_time_and_date() and show_calendar(). Indeed we have strftime() with great flexibility: 40 format specifiers, two modifiers O and E, 4 flags _, -, 0, and ^ (btw, all four flags are GNU extensions).

> I don't think glibc is intended to be used to construct natural sentences,
> in which case we would need support for every single case in every single
> language. 

...just for 12 (names) + 7 (weekdays) = 19 words in a language. It's not a big deal, is it?

Also, there is no need to prepare extended tables for all languages at once. If table is not yet extended, strftime should fallback to existing (nominative case) name.

> I don't think that's realistic or needed.

I always love people saying me "this is not needed" when I need it.

I already mentioned an example. Look at uk_UA locale definition:

>   % Initially alt_digits was supposed to hold alternative symbols for _digits_,
>   % corresponding to %O modified conversion specification.
>   % Although in Ukrainian language alternate _names_ are used instead of digits.
>   % We'll use this keyword to present a list of month names in proper form for
>   % date, see mon.  (%Om)
>   %
>   % This hack is dedicated for months it won't work for other %O* modifiers
>   % (weeks, days etc).

People need it, they have implemented a hack for it because there is no way to implement it in current infrastructure. (I am a bit surprised that this obvious hack was accepted by upstream.)

The uk_UA hack fixes the exact same problem that Rafal's patch is fixing: the lack of genitive month names. Could we please focus on that?

(In reply to Kalle Olavi Niemitalo from comment #30)
> In Finnish, all the month names end with "kuu" (moon) in the singular
> nominative, and you can form the genitive, partitive, or inessive by
> appending "n", "ta", or "ssa": tammikuu, tammikuun, tammikuuta, tammikuussa.
> So I think we can largely cover text output just by localizing the strftime
> format string.

You are lucky. What about weekday names?

(In reply to van.de.bugger from comment #35)
> You are lucky. What about weekday names?

In Finnish, most of those end with "tai", and their cases have simple suffixes. However, "keskiviikko" (Wednesday) is different.

maanantai, keskiviikko -- singular nominative
maanantain, keskiviikon -- singular genitive (or accusative)
maanantaita, keskiviikkoa -- singular partitive
maanantaina, keskiviikkona -- singular essive
maanantaiksi, keskiviikoksi -- singular translative
maanantaissa, keskiviikossa -- singular inessive
maanantaista, keskiviikosta -- singular elative
maanantaihin, keskiviikkoon -- singular illative
maanantailla, keskiviikolla -- singular adessive
maanantailta, keskiviikolta -- singular ablative
maanantaille, keskiviikolle -- singular allative
maanantaitta, keskiviikotta -- singular abessive

maanantait, keskiviikot -- plural nominative (or accusative)
maanantaiden, keskiviikkojen -- plural genitive
maanantaita, keskiviikkoja -- plural partitive
maanantaina, keskiviikkoina -- plural essive
maanantaiksi, keskiviikoiksi -- plural translative
maanantaissa, keskiviikoissa -- plural inessive
maanantaista, keskiviikoista -- plural elative
maanantaihin, keskiviikkoihin -- plural illative
maanantailla, keskiviikoilla -- plural adessive
maanantailta, keskiviikoilta -- plural ablative
maanantaille, keskiviikoille -- plural allative
maanantaitta, keskiviikoitta -- plural abessive
maanantaine-, keskiviikkoine- -- (plural) comitative (rare)
maanantain(?), keskiviikoin -- plural instructive (rare)

In many of these, the plural is written the same as the singular.

I suppose a calendar application could use:
- the singular nominative for column headers (Monday, Tuesday)
- the singular essive for dates of events (on Monday)
- the singular elative and illative for the starting and ending days of a multi-day event (spanning from Monday to Friday)
- the singular ablative and allative for the original and newly chosen dates of a rescheduled event (postponed from Tuesday to Wednesday)
- "keskiviikkoisin" (mentioned in comment #30; I'm not sure this is the instructive case of the adjective "keskiviikkoinen") for a recurring event

An email application that localizes the Date header might use only the singular essive, which can luckily be formed by appending "na" to the singular nominative case of any weekday and so doesn't need a separate format specifier in strftime. (Some other words aren't so lucky.) This assumes that the strftime format string is made localizable, but that should be done in any case because I don't see how a programmer could choose the correct grammatical cases without knowing the language. 

Are programmers or translators asking glibc to support any variants of weekday names other than what it already has?

(In reply to Kalle Olavi Niemitalo from comment #36)
> In Finnish, most of those end with "tai", and their cases have simple
> suffixes. However, "keskiviikko" (Wednesday) is different.

It means messages containing weekday names cannot be easily localized throug strftime format string: "%An" gives genitive case for all weekdays but Wednesday.

> Are programmers or translators asking glibc to support any variants of
> weekday names other than what it already has?

But today we have *only* nominative case, which is not enough for Russian language (at least). "%B" (month name in nominative case) is ok for month heading in calendar application, but "%d %B %Y" looks ugly because in this phrase month name should be in genitive case. However, if we change "mon" table in ru_RU locale definition to have month names in genitive cases to fix "%d %B %Y", we break "%B". 

So yes, at least few programmers/translators are asking for more. However, we can't get agreement on how much grammatical cases we want to have. Some guys here think two cases is enough while I believe we should not create artificial limits — let us have as many grammatical cases as required for the language.

> …This
> assumes that the strftime format string is made localizable, but that should
> be done in any case because I don't see how a programmer could choose the
> correct grammatical cases without knowing the language. 

You get the point.

Microsoft Windows provides:
- GetCalendarInfoEx can retrieve the name of a month or the name of a day of the week. The nominative case is the default. For months only, the caller can add the CAL_RETURN_GENITIVE_NAMES flag.
- GetDateFormatEx formats a date according to a format picture string in which "MMMM" represents the name of the month.  The caller cannot explicitly request the genitive case. The function uses heuristics instead, and they don't always work perfectly.

https://msdn.microsoft.com/en-us/library/windows/desktop/dd317734(v=vs.85).aspx
"Calendar Type Information (Windows)"

http://www.siao2.com/2011/10/26/10230215.aspx
"Improving genitive. Or not…. (part 2): Explaining the point of Part 1"

(In reply to Rafal Luzynski from comment #7)
> 3. Mimic the *BSD specification but implement it conversely: let %B retrieve
> the nominative case (as it currently does) and let the new %OB specifier
> retrieve the genitive case. See also:
> http://austingroupbugs.net/view.php?id=258 - this seems to has accepted this
> solution.

The Final Accepted Text in Austin Group bug 258 contains:
"alt_mon Define the full month names, corresponding to the %OB conversion specification. [...] For languages having both a genitive (when used with a day number) and a nominative (no day number) case, this operand shall be used to denote the nominative case."

The FreeBSD strftime(3) page says: "Additionally %OB implemented to represent alternative months names (used standalone, without day mentioned)." I believe this means the nominative case.

So %OB retrieves the nominative case in both of them; I don't see any conflict. The same could be implemented in glibc.

Thank you for all your comments and I'm sorry for not being able to reply immediately.

(In reply to Kalle Olavi Niemitalo from comment #39)
> [...]
> The Final Accepted Text in Austin Group bug 258 contains:
> "alt_mon Define the full month names, corresponding to the %OB conversion
> specification. [...] For languages having both a genitive (when used with a
> day number) and a nominative (no day number) case, this operand shall be
> used to denote the nominative case."
> 
> The FreeBSD strftime(3) page says: "Additionally %OB implemented to
> represent alternative months names (used standalone, without day
> mentioned)." I believe this means the nominative case.
> 
> So %OB retrieves the nominative case in both of them; I don't see any
> conflict. The same could be implemented in glibc.

Oops, somehow I must have read it backwards. :-) Having read this again carefully now I lean into the solution which is common to *BSD and POSIX which means that:

- nl_langinfo(ALT_MON_...) and strftime("%OB") both retrieve the nominative case,
- nl_langinfo(MON_...) and strftime("%B") both retrieve the genitive case (which is different than now!),
- for the locales which do not support genitive cases the nominative case is returned instead.

Will you agree for this solution?

Pros:
- full compatibility with *BSD and POSIX,
- simple and deterministic implementation,
- full programmer's control on whether they want a nominative or genitive case,
- will automagically fix all dates using %B conversion specifiers and displaying the nominative case which is incorrect (full dates).

Cons:
- at the same time will break formatting of all dates using %B conversion specifiers where the nominative case is required and is correctly provided now (e.g., calendar headers), the application developer may not even be aware that the application became broken in some languages,
- therefore will require urgent intervention from some application developers,
- it will be difficult or even impossible to provide a backward compatible solution which would detect if the current runtime version of glibc requires %OB or %B for the month name in nominative case.

This also means that the comment 7 does not make sense. The solution 3 should be merged into 2 because they actually should be the same, and solution 1 is no longer needed since 2 is common for *BSD and POSIX.

Some answers:


(In reply to keld@keldix.com from comment #29)
> [...]
> Well, can we see what is the extent of the problem?
> Russian, Polish, possibly all of the Slavian languages, Finnish,
> Hungarian, Estonian?

Comment 6 says that all Slavonic languages except Bulgarian and Macedonian, plus Finnish, https://bugzilla.gnome.org/show_bug.cgi?id=749206#c6 mentions Greek, I have accidentally found in CLDR that Baltic languages are injured, too. Roughly whole Eastern half of Europe with some exceptions plus some Western European languages (Icelandic?) Plus unknown number of non-European languages. For a full list you should browse the CLDR database.


(In reply to van.de.bugger from comment #31)
> [...]
> BTW, I found a dirty hack in glibc: uk_UA locale has *month names* in
> genitive case in alt_digits table. Now they can get month name in genitive
> case by %Om, but applying modifier O to another format specifier (like %Od,
> %Of, %OH) is meaningless: %OI converts hour to a months name in genitive
> case... 

Please see my patch for Ukrainian.

I searched for uses of the strftime-style %B in the Finnish PO files at <http://translationproject.org/extra/matrix.html>. I found only the following:

http://translationproject.org/PO-files/fi/a2ps-4.14.fi.po
msgid "%A %B %d, %Y"
msgstr "%A, %e. %Bta %Y"

http://translationproject.org/PO-files/fi/help2man-1.46.6.fi.po
msgid "%B %Y"
msgstr "%B %Y"

http://translationproject.org/PO-files/fi/coreutils-8.25-pre1.fi.po
A list of all the strftime format specifiers.

If the glibc Finnish locale were changed to expand "%B" to the genitive case and "%OB" to the nominative case, the change would break those for no benefit to translators or users. There aren't many uses of "%B" in the Finnish PO files but users may also have strftime format strings in date commands in shell scripts. I think the Finnish locale should not be changed as part of fixing this Russian bug.

Three occurrences is not much and can be easily changed. Although you don't know how many projects not listed at translationproject.org will also be affected. But if appending "ta" to the nominative month name is a correct way to achieve a desired genitive form and this works for all months then you can use the "%Bta" format specifier and you don't need this new feature. Note that if locales do not provide the alternative month names then basic names will be returned for both "%B" and "%OB". You can choose whatever you find more appropriate. Unfortunately, some other languages have too complex rules to have such an easy workaround.

Any chance of picking this up? The original issue is still there.

Sorry for this delay. I was overwhelmed with other projects. I'd like to use Fedora and GNOME freeze period which will be soon to return to this bug. glibc 2.23 has just been released after its freeze, I guess that 2.24 will be released in August so now seems to be a good time to come back. Things to do:

* As Mike pointed out here: https://sourceware.org/ml/libc-alpha/2016-01/msg00152.html I should remove the additional array containing the same month names as another one.
* As pointed out in comment 39 I have completely misunderstood the intentions of POSIX specification and I must reimplement the solution. Fortunately, the new implementation will be easier and to rework the old solution I must remove the heuristic code guessing if this is full date or just a month name and replace nominative case with genitive case in few places.

That means we are on a good path. I don't want to promise any specific date when it will land but I hope it would be soon. Of course, everybody are welcome to rework my patches.

Created attachment 9122 [details]
Proposed solution: support alternative month names (version 2)

This patch implements the new approach: we no longer need day-month-order trick (as pointed out in comment 39). Also fixes a bug: defines alternative month names to the empty string in the default (fallback) C locale.

Created attachment 9123 [details]
Add tests for the alternative month names (v2)

Actually not different from the old version, the only difference is that the subject line says it's PATCH 2/6 rather than PATCH 2/7.

Created attachment 9124 [details]
Proposed solution: implement the %OB format specifier

As pointed out in comment 39 implementing %OB format specifier is more correct solution than implementing a smart algorithm trying to guess if we are in the full date context or standalone. %B retrieves the default month name which is genitive from now (this is the change!) in those languages which need a genitive. %OB retrieves the alternative month name which is nominative in those languages which need it (this is the change because previously the default month name was nominative), also it returns the same as %B for those languages which do not need this feature or do not yet provide the updated locale. This means that %B does not have to be changed in most cases but in some cases it *must* be changed to %OB.

Created attachment 9125 [details]
Alternative month names NLS data (Polish, v2)

The change in this patch is that the mon and alt_mon arrays have been replaced. Previously I misunderstood their meaning, as pointed out in comment 39.

As previously, you can treat this patch as a test data. You can provide the updated locales from more reliable source but you will not see the effect of the change without the updated locale.

Created attachment 9126 [details]
Alternative month names NLS data (Russian, v2)

Same as above.

Created attachment 9127 [details]
Alternative month names NLS data (Ukrainian, v2)

Same as above. Enjoy!

Any progress on the patches review? I desperately need to get this fixed. :(

Sorry for the delay, recently I was overwhelmed with another Linux related project. The last response is that this change breaks ABI so versioning should be implemented to retain the backward compatibility. [1] [2]  Unfortunately, I'll have to learn more about it as this concept is new for me.  Fortunately, also I got some tips about it but more tips would be welcome.

Piotr, believe me, I find this bug as blatant as you do.


[1] https://sourceware.org/ml/libc-alpha/2016-06/msg00009.html
[2] https://sourceware.org/ml/libc-alpha/2016-06/msg00019.html

Created attachment 9569 [details]
Proposed solution: support alternative month names (version 3)

Here is the new patch set including backward compatibility via the function versioning.

This first patch is actually the same as the one in comment 45, it's only rebased.

Created attachment 9570 [details]
Provide backward compatibility for nl_langinfo family

As requested in [1] and [2] this patch defines backward compatible versions of nl_langinfo() and nl_langinfo_l(). Is this sufficient? Can we assume that __nl_langinfo_l() is a private API (even if visible in public) and it is not guaranteed to be backward compatible?

[1] https://sourceware.org/ml/libc-alpha/2016-06/msg00009.html
[2] https://sourceware.org/ml/libc-alpha/2016-06/msg00019.html

Created attachment 9571 [details]
Rebuild abilists to reflect nl_langinfo changes

The changes in this patch are automatically generated.

Created attachment 9572 [details]
Add tests for alternative month names (v3)

Actually it's the same as the patch provided in comment 46, the only difference is that the subject line says it's PATCH 04/11 rather than PATCH 2/6.

Created attachment 9573 [details]
Proposed solution: implement the %OB format specifier (v3)

Actually it's the same patch as the one provided in comment 47, the only difference is that the subject line says it's PATCH 05/11 rather than PATCH 3/6.

__nl_langinfo_l is at a public symbol version and used by libstdc++ 
(libstdc++ needs to use internal symbols like that for namespace reasons; 
indeed, we probably need to add more such exports for libstdc++ use).  It 
needs to stay backward compatible.

Created attachment 9574 [details]
Provide backward compatibility for strftime family

This patch provides backward compatibility feature for the functions: strftime(), strftime_l(), wcsftime(), and wcsftime_l(). The backward compatible versions ignore the %OB format specifier and for the format specifier %B return the same results as %OB does for the new version.

Is this sufficient? This patch does not provide the backward compatibility for strptime() and strptime_l(). Do we need a backward compatible version? The possible backward compatible version would:

* return an error code if %OB format specifier is found,
* match the month names only against the nominative form (but since the month is recognized after the longest matching substring at the beginning the results will be usually the same no matter if we match nominative or genitive cases).

Created attachment 9575 [details]
Rebuild abilists to reflect strftime family changes

Same as the patch in comment 55, this patch contains the automatically generated changes.

Created attachment 9576 [details]
Alternative month names NLS data (Polish, v3)

This patch has been rebased against the current master.

As previously, you can treat this patch as a test data. You can provide the updated locales from more reliable source but you will not see the effect of the change without the updated locale.

Created attachment 9577 [details]
Alternative month names NLS data (Russian, v3)

Same comment as above.

Created attachment 9578 [details]
Alternative month names NLS data (Ukrainian, v3)

Same comment as above.

Created attachment 9579 [details]
Alternative month names NLS data (Czech)

New bonus: this patch contains an example of NLS data containing nominative and genitive month names in Czech. Enjoy!

Created attachment 9595 [details]
Proposed solution: support alternative month names (version 4)

Here goes a new set of patches. Some are skipped in this set because they have not been changed.

The difference between the version from comment 53 and this one: this patch does not add anything to conform/data/langinfo.h-data, as requested in https://sourceware.org/ml/libc-alpha/2016-10/msg00303.html

Created attachment 9596 [details]
Provide backward compatibility for nl_langinfo family (version 4)

This patch, compared to the one from comment 54, provides backward compatibility not only to nl_langinfo() and nl_langinfo_l() but also to __nl_langinfo_l(), as requested in comment 58.

Note: the patch description says "(version 4)" only for the consistency with other v4 patches.

Created attachment 9597 [details]
Rebuild abilists to reflect nl_langinfo changes (version 4)

Same changes as above, also this patch is rebased against the current master.

--------

SKIPPED PATCHES:
* Patch 0004 could go here, skipped because it is the same as in comment 56.
* Patch 0005 could go here, skipped because it is the same as in comment 57.

Created attachment 9598 [details]
Provide backward compatibility for strftime family (version 4)

This patch, compared to the one from comment 59, provides backward compatibility not only to strftime(), strftime_l(), wcsftime(), and wcsftime_l() but also to __strftime_l() and __wcsftime_l(), as requested in https://sourceware.org/ml/libc-alpha/2016-10/msg00304.html

Created attachment 9599 [details]
Rebuild abilists to reflect strftime family changes (version 4)

Same changes as above, also this patch is rebased against the current master.

--------

SKIPPED PATCHES:
0008 (Polish) - same as in commment 61
0009 (Russian) - same as in commment 62
0010 (Ukrainian) - same as in commment 63
0011 (Czech) - same as in commment 64

Also note that those patches only provide the test data, they are not intended to be committed (although I don't mind if you decide so.)

Created attachment 9709 [details]
Proposed solution: support alternative month names (version 5)

Here goes the new set of patches.

The main difference is what I realized after comparing how this problem has been solved in other systems.  My idea that alt_mon should be optional was wrong.  Making it obligatory simplifies the code, we don't have to check if a particular alternative month name is NULL or empty.  Locale data are part of glibc, we are able to provide the data fulfilling our own requirements.  For the languages which do not need two forms of months names this means that months names must be copied from mon to alt_mon even although both forms are identical.

Difference between this patch and the one from comment 65: alt_mon locale data section made obligatory.

Created attachment 9710 [details]
Provide backward compatibility for nl_langinfo family (version 5)

Differences between the patch from comment 66 and this one:

* dirty aliases ending with "2" (e.g., "__nl_langinfo_noaltmon_l2") replaced with more decent ending with "_alias" (e.g., "__nl_langinfo_noaltmon_l_alias");
* alt_mon section made obligatory, no need to check for NULLs and empty strings.

Created attachment 9711 [details]
Rebuild abilists to reflect nl_langinfo changes (version 5)

Compared to the one from comment 67: rebased against the current master.

Created attachment 9712 [details]
Add tests for alternative month names (v5)

Actually the same as the patch in comment 56 and comment 46, only the subject line changed to PATCH 04/13 (instead of 4/11 or 2/6).

Created attachment 9713 [details]
Proposed solution: implement the %OB format specifier (v5)

Difference between the patch from comment 57 and comment 47: as alt_mon is obligatory no need to check for NULLs and empty strings, this simplifies the code a little.

Created attachment 9714 [details]
Provide backward compatibility for strftime family (version 5)

Compared to the one from comment 68 this patch is a little simpler because there is no need to check if alt_mon is NULL or empty, as it is obligatory now.  Also replaces dirty alias names ending with "2" (like "__strftime_l_compat2") with more decent ending with "_alias" (like "__strftime_l_compat_alias").

Created attachment 9715 [details]
Rebuild abilists to reflect strftime family changes (version 5)

Compared to the one from comment 69: rebuilt against the current master.

Created attachment 9716 [details]
Alternative month names NLS data (Polish, v5)

Compared to the one from comment 61: no changes, only the subject line says "[PATCH 08/13]".

Created attachment 9717 [details]
Alternative month names NLS data (Russian, v5)

Compared to the one from comment 62: similar change as above.

Created attachment 9718 [details]
Alternative month names NLS data (Ukrainian, v5)

Compared to the one from comment 63: similar change as above.

Created attachment 9719 [details]
Alternative month names NLS data (Czech, v5)

Compared to the one form comment 64: similar change as above.

Created attachment 9720 [details]
Alternative month names for all locales

All month names (mon sections) in all supported languages (except those in the patches above) copied into alt_mon sections.

Created attachment 9721 [details]
Import month names from CLDR

This patch imports month names from CLDR, where alt_mon sections are not just copies of mon sections.  This adds actual full genitive/nominative support to 15 new locales, together with 4 supported previously makes total 19 locales (17 unique languages because Greek and Russian appear twice).  Other changes are only partially related with the nominative/genitive cases or totally unrelated, just spotted while importing data.

This is the end of this set of patches.

Created attachment 9908 [details]
Proposed solution: support alternative month names (version 6)

Here is the new set of patches.

Differences between the patch from comment 70 and this one:

- alt_mon section in locale data source made optional again, like in comment the data will be generated while compiling to binary;
- comments reworded not to suggest that alt_mon is standalone (nominative) and mon is for formatting full date (genitive), this will be decided later;
- ALTMON_x macros defined only if __USE_GNU is defined; for now they are treated as GNU-only extension.

Created attachment 9909 [details]
Provide backward compatibility for nl_langinfo family (version 6)

Difference between the patch from comment 71 and this one: glibc version rebased from 2.25 to 2.26.

Created attachment 9910 [details]
Rebuild abilists to reflect nl_langinfo changes (version 6)

Differences between the patch from comment 72 and this one:

- glibc version rebased from 2.25 to 2.26,
- this also adds the symbol GLIBC_2.26 because it does not exist yet.

--------

SKIPPED PATCH:

0004 Add tests for alternative month names - same as in comment 73 except the subject line changed

Created attachment 9911 [details]
Proposed solution: implement the %OB format specifier (v6)

Difference between the patch from comment 74: commit comment reworded not to suggest that %OB is standalone (nominative) and %B is for full date format (nominative), this will be decided later.  Really no changes in the code.

Created attachment 9912 [details]
Provide backward compatibility for strftime family (version 6)

Difference between the patch from comment 75 and this one: glibc version rebased from 2.25 to 2.26.

Created attachment 9913 [details]
Rebuild abilists to reflect strftime family changes (version 6)

Difference between the patch from comment 76 and this one: glibc version rebased from 2.25 to 2.26.

Hi 

I would ask that our changes are backwards compatible, so that we need not change 
the existing data, just addin new data, (and changing the date format spec).

Something like the %B is the nominative case, %OB is the genitive case, and then
the full date spec is using %OB for the month names when required.

And the alt_mon is an optional keyword, and general. I believe these changes are
getting their way into both POSIX and i18n 30112 standards.

Best regads
keld

Created attachment 9914 [details]
Let alternative month names be a copy of regular ones

This is a new patch: alt_mon section is optional in the locale data source file but this patch modifies the compiler to generate the missing alt_mon section as a copy of mon section in the binary output file.

The difference between the patch from comment 81 and this one is not obvious: the old patch actually added alt_mon section to all source files while this one makes them unnecessary and generates the missing data automatically.

Created attachment 9915 [details]
Also implement abbreviated alternative month names and %Ob

This is a new patch.  I realized that at least in case of May in Russian and Belarusian also abbreviated month names may have nominative/genitive form, in this particular case because the word is so short that its abbreviated form equals the full form.  A similar phenomenon may also exist in other languages which I am not yet aware of.  So this patch repeats all the above steps to implement _NL_ABALTMON_x constants in nl_langinfo() and "%Ob" format specifier in strftime(), except the backward compatibility.

Created attachment 9916 [details]
Backward compatibility for abbreviated alternative month names and %Ob

This is a new patch.  Repeats the backward compatibility steps also for _NL_ABALTMON_x constants in nl_langinfo() and "%Ob" format specifier in strftime().

--------

SKIPPED PATCH:
0011 (Polish) - same as in comment 77

Created attachment 9917 [details]
Alternative month names NLS data (Russian, v6)

Differences between the patch from comment 78 and this one:

- Adds ab_alt_mon section (this is an example of how and why this feature can be used).
- No longer changes the nominative cases to lowercase.  CLDR suggests to use the standalone/full-date-format feature to start standalone cases with uppercase letter even for the languages which don't need always the uppercase letter because a standalone word is an expression by itself (like a sentence).  I'm not sure if the Russian language community will like it, let them decide.  This is just an example, I don't suggest they will actually push it without changes.

--------

SKIPPED PATCHES:
0013 (Ukrainian) - same as in commment 79
0014 (Czech) - same as in commment 80

Created attachment 9918 [details]
Import genitive month names from CLDR (v6)

Differences between the patch from comment 82 and this one:

- only those languages which have and need the nominative/genitive case in dates are imported here;
- this new patch does not assume that alt_mon section already exists (the patch from comment 81 is obsoleted/rejected) so it adds these sections;
- be_BY: also adds ab_alt_mon section;
- wa_BE: adds a space after "d’" which I did not know was needed.

Created attachment 9919 [details]
Import uppercase/lowercase month names from CLDR (v6)

Some languages which don't need the genitive/nominative difference already use this feature in CLDR to start the month names with uppercase if they are standalone and with lowercase when they are in full date context.  This was already imported previously in the comment 82, this patch splits out these cases.

Hi,

(In reply to keld@keldix.com from comment #89)
> Hi 
> 
> I would ask that our changes are backwards compatible, so that we need not
> change 
> the existing data, just addin new data, (and changing the date format spec).
> 
> Something like the %B is the nominative case, %OB is the genitive case, and
> then
> the full date spec is using %OB for the month names when required.

It's been discussed here and in the libc-alpha list.  The current consensus is that whether you decide that %B is nominative or %OB is genitive or the other way round does not change the source code: the difference is only on input (locale data) and output (format specifiers in applications).  Both controlled by language communities.  So these changes are acceptable as long as they do not suggest which is nominative and which is genitive and this will be decided later.  By later I mean later in this development cycle, not later in a distant future.

Also I have some reasons why I suggest switching %B to genitive and introduce %OB as nominative which I published many times before (links available).

> And the alt_mon is an optional keyword, and general.

Done in this series of patches.

> I believe these changes are
> getting their way into both POSIX and i18n 30112 standards.

POSIX has accepted (but not yet published) the opposite solution: http://austingroupbugs.net/view.php?id=258.  Regarding ISO 30112 I'm not aware of their opinion about it.  Can you please provide some more up to date info?

I have already prepared a copr repository for any modern Fedora so if you are brave enough you can install it and test already how many applications are fixed and how many are broken because of these changes.  I'll be glad to hear your feedback. The repo is at https://copr.fedorainfracloud.org/coprs/rluzynski/genitive/

Created attachment 10063 [details]
Rebuild abilists to reflect nl_langinfo changes (version 7)

Here is the new set of patches with really minor changes.  Due to this most of the patches are skipped:

--------

SKIPPED PATCHES:

0001 Implement alternative month names - same as in comment 83
0002 Provide backward compatibility for nl_langinfo family - same as in comment 84

--------

This is the new patch 0003.  Difference between the patch from comment 85 and this one: rebased against the current master (NaCl port removed)

--------

MORE SKIPPED PATCHES:

0004 Add tests for alternative month names - same as in comment 73 except the subject line changed
0005 Implement the %OB specifier - alternative month names - same as in comment 86

Created attachment 10064 [details]
Provide backward compatibility for strftime family (version 7)

Difference between the patch from comment 87 and this one: rebased against the current master

Created attachment 10065 [details]
Rebuild abilists to reflect strftime family changes (version 7)

Difference between the patch from comment 88 and this one: rebased against the current master (NaCl port removed)

--------

SKIPPED PATCHES:

All other patches are skipped because they have not been changed:

0008 Let alternative month names be a copy of regular ones - same as in comment 90
0009 Abbreviated alternative month names (%Ob) also added - same as in comment 91
0010 Backward compatibility for abbreviated alternative month names and %Ob - same as in comment 92
0011 pl_PL: Add alternative month names - same as in comment 77
0012 ru_RU: Add alternative month names - same as in comment 93
0013 uk_UA: Add alternative month names - same as in comment 79
0014 cs_CZ: Add alternative month names - same as in comment 80
0015 Genitive month names imported from CLDR - same as in comment 94
0016 Month names imported from CLDR (upper/lower case) - same as in comment 95

Created attachment 10225 [details]
Provide backward compatibility for nl_langinfo family (version 8)

Here is the new set of patches.  The changes are mostly the rebase to the current master and applying the latest changes in the source code repository (like: Use locale_t, not __locale_t https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=af85385).  Some patches are skipped because there are no relevant changes:

--------

SKIPPED PATCHES:

0001 Implement alternative month names - same as in comment 83

--------

This is the new patch 0002.  Difference between the patch from comment 84 and this one: rebased against the current master, reflects the change to use locale_t rather than __locale_t.

Created attachment 10226 [details]
Rebuild abilists to reflect nl_langinfo changes (version 8)

This is the new patch 0003.  Difference between the patch from comment 97 and this one: rebased against the current master (new functions have been added by previously accepted patches).

--------

SKIPPED PATCH:

0004 Add tests for alternative month names - same as in comment 73

Created attachment 10227 [details]
Proposed solution: implement the %OB format specifier (version 8)

Difference between the patch from comment 86 and this one: rebased against the current master.

Created attachment 10228 [details]
Provide backward compatibility for strftime family (version 8)

Difference between the patch from comment 98 and this one: rebased against the current master, uses locale_t instead of __locale_t.

Created attachment 10229 [details]
Rebuild abilists to reflect strftime family changes (version 8)

Differences between the patch from comment 99 and this one: rebased against the current master (new functions added by the previously accepted patches).

--------

SKIPPED PATCH:

0008 Let alternative month names be a copy of regular ones - same as in comment 90

Created attachment 10230 [details]
Also implement abbreviated alternative month names and %Ob (version 8)

Differences between the patch from comment 91 and this one: rebased against the current master.

Created attachment 10231 [details]
Backward compatibility for abbreviated alternative month names and %Ob (version 8)

Differences between the patch from comment 92 and this one: rebased against the current master, uses locale_t rather than __locale_t.

--------

SKIPPED PATCHES:

All other patches are skipped because they have not been changed:

0011 pl_PL: Add alternative month names - same as in comment 77
0012 ru_RU: Add alternative month names - same as in comment 93
0013 uk_UA: Add alternative month names - same as in comment 79
0014 cs_CZ: Add alternative month names - same as in comment 80
0015 Genitive month names imported from CLDR - same as in comment 94
0016 Month names imported from CLDR (upper/lower case) - same as in comment 95

Created attachment 10425 [details]
Correct the size of _nl_value_type_LC_... arrays (v9)

This is the new series of patches, attempting to be prepared to the final commit.

This patch is not directly related with this bug but necessary to be pushed before the other patches.  More related with bug 356.  I was asked to split it out.  Previously these changes were included in the patch attached in the comment 83.

Created attachment 10426 [details]
Implement alternative month names (v9)

This patch merges everything related with adding the alternative month names: nl_langinfo(ALTMON_…) and strftime("%OB").  At the same time it splits out the changes from the previous comment and some automatically generated files.

Created attachment 10427 [details]
Regenerate locfile-kw.h from locfile-kw.gperf (v9)

This patch contains changes to the automatically generated file split out from the previous patch because I was asked not to post them to libc-locale mailing list.  But these changes still need to be pushed to the repository so I post them here.

Created attachment 10428 [details]
Also implement abbreviated alternative month names and %Ob (v9)

Differences since the patch posted in the comment 105:
- in the default C locale, default abbreviated alternative month names initialized explicitly to "Jan", "Feb", etc.,
- changes to an automatically generated file split out,
- ChangeLog updated.

Created attachment 10429 [details]
Again regenerate locfile-kw.h from locfile-kw.gperf (v9)

Again the changes to an automatically generated file split out from the previous patch.

Created attachment 10430 [details]
Documentation to the above changes(v9)

This patch is new, updates the local documentation: NEWS and texinfo files.

What will happen with other patches:

- backward compatibility patches most probably will be rejected, please ignore for now,
- updates to the locale data: probably will be regenerated and pushed later, for now please treat them as sample data necessary to actually use the newly added features and see the difference.

Created attachment 10592 [details]
Implement alternative month names (v10)

Here is the new series of patches.  Changes:

- Fixed bug in strptime(), thanks Zack Weinberg for fixing it.
- Improved documentation, again thanks Zack Weinberg.
- Rebased to the current master.

Created attachment 10593 [details]
Regenerate locfile-kw.h from locfile-kw.gperf + ChangeLog (v10)

Created attachment 10594 [details]
Also implement abbreviated alternative month names and %Ob (v10)

Created attachment 10595 [details]
Again regenerate locfile-kw.h from locfile-kw.gperf + ChangeLog (v10)

Created attachment 10596 [details]
Documentation to the above changes(v10)

--------

SKIPPED PATCHES:

0006 Provide backward compatibility for nl_langinfo family
0007 Rebuild abilists to reflect nl_langinfo changes
0008 Provide backward compatibility for strftime family
0009 Rebuild abilists to reflect strftime family changes
0010 Backward compatibility for abbreviated alternative month names and %Ob

Most probably they will be dropped so I think there is no need to maintain them.
Those who want their rebased version can find them on github.

Created attachment 10597 [details]
Alternative month names NLS data (Polish, v10)

Created attachment 10598 [details]
Alternative month names NLS data (Russian, v10)

Created attachment 10599 [details]
Alternative month names NLS data (Ukrainian, v10)

Created attachment 10600 [details]
Alternative month names NLS data (Czech, v10)

Note: Czech language community may not like these changes.  This patch should not be committed without asking them about their opinion.

Created attachment 10601 [details]
Import genitive month names from CLDR (v10)

Created attachment 10602 [details]
Import uppercase/lowercase month names from CLDR (v10)

Created attachment 10731 [details]
Implement alternative month names (v11)

Here is the new series posted to libc-alpha on January 9.  I upload it here mostly for the completeness and to facilitate tracking changes.  There are no major changes in this series, mostly rebased to the current master.

Created attachment 10732 [details]
Regenerate locfile-kw.h from locfile-kw.gperf + ChangeLog (v11)

Created attachment 10733 [details]
Also implement abbreviated alternative month names and %Ob (v11)

Created attachment 10734 [details]
Again regenerate locfile-kw.h from locfile-kw.gperf + ChangeLog (v11)

Created attachment 10735 [details]
Documentation to the above changes (v11)

Created attachment 10736 [details]
Alternative month names NLS data (Polish, v11)

This patch is a little reordered, the mon array is placed immediately after the alt_mon array (rather than at the end of the LC_TIME section).

Created attachment 10737 [details]
Implement alternative month names (v12)

Here is the new series posted to libc-alpha on January 12.  I upload it here for the completeness and to facilitate tracking changes.  This new series contains documentation updates (commit comments, changelog, etc.), thank you Dmitry and Carlos for your recent reviews and remarks.

Created attachment 10738 [details]
Regenerate locfile-kw.h from locfile-kw.gperf + ChangeLog (v12)

Created attachment 10739 [details]
Also implement abbreviated alternative month names and %Ob (v12)

Created attachment 10740 [details]
Again regenerate locfile-kw.h from locfile-kw.gperf + ChangeLog (v12)

Created attachment 10741 [details]
Documentation to the above changes (v12)

Created attachment 10742 [details]
Alternative month names NLS data (Polish, v12)

This version also contains an example of parsing the date (strptime) with the month name in a genitive case (required for correctness) in Polish language in the test file.

Also the previous patches contain some more date parsing test cases.

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  2aa8009d21802f700c4b47cb8e0c7e71fe915ba2 (commit)
       via  22390764f9ef3b04ae71ad100af6282f677315c2 (commit)
       via  761a585ce9245d5ad968303b200eef1f26fd501c (commit)
       via  95cb863a1ef7760a11272bbd7ba5fe62dc41be54 (commit)
      from  4612268a0ad8e3409d8ce2314dd2dd8ee0af5269 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2aa8009d21802f700c4b47cb8e0c7e71fe915ba2

commit 2aa8009d21802f700c4b47cb8e0c7e71fe915ba2
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Tue Jan 5 03:03:10 2016 +0100

    pl_PL: Add alternative month names (bug 10871).
    
    	[BZ #10871]
    	* localedata/locales/pl_PL: Alternative month names added,
    	primary month names are genitive now.
    	* time/tst-strptime.c (day_tests): Actually use a genitive case
    	of a month name in Polish language.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=22390764f9ef3b04ae71ad100af6282f677315c2

commit 22390764f9ef3b04ae71ad100af6282f677315c2
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Tue Sep 19 00:00:22 2017 +0200

    Documentation to the above changes (bug 10871).
    
    	[BZ #10871]
    	* manual/locale.texi: Document ALTMON_1..12 constants for
    	nl_langinfo.  Specify when to use ALTMON instead of MON.
    	* manual/time.texi (strftime, strptime): Document GNU extension
    	permitting O modifier with %B and %b.  Specify when to use
    	%OB instead of %B.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=761a585ce9245d5ad968303b200eef1f26fd501c

commit 761a585ce9245d5ad968303b200eef1f26fd501c
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Tue Nov 14 02:22:38 2017 +0100

    Abbreviated alternative month names (%Ob) also added (bug 10871).
    
    All the previous changes also repeated to support abbreviated
    alternative month names.  In most languages which have declension and
    need nominative/genitive month names the abbreviated forms for both
    cases are the same.  An example where they do differ is May in Russian:
    this name is too short to be abbreviated so even the abbreviated form
    features the declension suffixes.
    
    	[BZ #10871]
    	* locale/C-time.c (_nl_C_LC_TIME): Add abbreviated alternative month
    	names, define them as the same as abbreviated month names explicitly.
    	* locale/categories.def (LC_TIME): Add ab_alt_mon and wide-ab_alt_mon.
    	* locale/langinfo.h: (_NL_ABALTMON_1, _NL_ABALTMON_2, _NL_ABALTMON_3,
    	_NL_ABALTMON_4, _NL_ABALTMON_5, _NL_ABALTMON_6, _NL_ABALTMON_7,
    	_NL_ABALTMON_8, _NL_ABALTMON_9, _NL_ABALTMON_10, _NL_ABALTMON_11,
    	_NL_ABALTMON_12, _NL_WABALTMON_1, _NL_WABALTMON_2, _NL_WABALTMON_3,
    	_NL_WABALTMON_4, _NL_WABALTMON_5, _NL_WABALTMON_6, _NL_WABALTMON_7,
    	_NL_WABALTMON_8, _NL_WABALTMON_9, _NL_WABALTMON_10, _NL_WABALTMON_11,
    	_NL_WABALTMON_12): New enum constants.
    	* locale/programs/ld-time.c (struct locale_time_t): Add ab_alt_mon,
    	wab_alt_mon, and ab_alt_mon_defined members.
    	(time_output): Output ab_alt_mon and wab_alt_mon members.
    	(time_read): Read them, initialize them as copies of abmon and wabmon
    	respectively if they are missing, initialize ab_alt_mon_defined.
    	* locale/programs/locfile-kw.gperf (ab_alt_mon): Define.
    	* locale/programs/locfile-kw.h: Regenerate.
    	* locale/programs/locfile-token.h (tok_ab_alt_mon): New enum constant.
    	* time/Makefile [$(run-built-tests) = yes] (LOCALES): Add es_ES.UTF-8
    	and ru_RU.UTF-8.
    	* time/strftime_l.c (a_altmonth, aam_len): New macros.
    	[!COMPILE_WIDE] (ABALTMON_1): New macro.
    	(__strftime_internal): Handle %Ob and %Oh formats.
    	* time/strptime_l.c [_LIBC] (ab_alt_month_name): New macro.
    	(__strptime_internal): Handle %Ob and %Oh formats.
    	* time/tst-strptime.c (day_tests): Add more tests to parse different
    	forms of month names including the new %Ob format specifier.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=95cb863a1ef7760a11272bbd7ba5fe62dc41be54

commit 95cb863a1ef7760a11272bbd7ba5fe62dc41be54
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Tue Nov 14 02:19:35 2017 +0100

    Implement alternative month names (bug 10871).
    
    Some languages (Slavic, Baltic, etc.) require a genitive case of the
    month name when formatting a full date (with the day number) while
    they require a nominative case when referring to the month standalone.
    This requirement cannot be fulfilled without providing two forms for
    each month name.  From now it is specified that nl_langinfo(MON_1)
    series (up to MON_12) and strftime("%B") generate the month names in
    the grammatical form used when the month is a part of a complete date.
    If the grammatical form used when the month is named by itself is needed,
    the new values nl_langinfo(ALTMON_1) (up to ALTMON_12) and
    strftime("%OB") are supported.  This new feature is optional so the
    languages which do not need it or do not yet provide the updated
    locales simply do not use it and their behaviour is unchanged.
    
    	[BZ #10871]
    	* locale/C-time.c (_nl_C_LC_TIME): Add alternative month names,
    	define them as the same as primary full month names explicitly.
    	* locale/categories.def (LC_TIME): Add alt_mon and wide-alt_mon.
    	* locale/langinfo.h (__ALTMON_1, __ALTMON_2, __ALTMON_3, __ALTMON_4,
    	__ALTMON_5, __ALTMON_6, __ALTMON_7, __ALTMON_8, __ALTMON_9, __ALTMON_10,
    	__ALTMON_11, __ALTMON_12, _NL_WALTMON_1, _NL_WALTMON_2, _NL_WALTMON_3,
    	_NL_WALTMON_4, _NL_WALTMON_5, _NL_WALTMON_6, _NL_WALTMON_7,
    	_NL_WALTMON_8, _NL_WALTMON_9, _NL_WALTMON_10, _NL_WALTMON_11,
    	_NL_WALTMON_12): New enum constants.
    	[__USE_GNU] (ALTMON_1, ALTMON_2, ALTMON_3, ALTMON_4, ALTMON_5, ALTMON_6,
    	ALTMON_7, ALTMON_8, ALTMON_9, ALTMON_10, ALTMON_11, ALTMON_12): New
    	macros.
    	* locale/programs/ld-time.c (struct locale_time_t): Add alt_mon,
    	walt_mon, and alt_mon_defined members.
    	(time_output): Output alt_mon and walt_mon members.
    	(time_read): Read them, initialize them as copies of mon and wmon
    	respectively if they are missing, initialize alt_mon_defined.
    	* locale/programs/locfile-kw.gperf (alt_mon): Define.
    	* locale/programs/locfile-kw.h: Regenerate.
    	* locale/programs/locfile-token.h (tok_alt_mon): New enum constant.
    	* localedata/tst-langinfo.c (map): Add tests for the new constants
    	ALTMON_1 .. ALTMON_12.
    	* time/Makefile [$(run-built-tests) = yes] (LOCALES): Add fr_FR.UTF-8
    	and pl_PL.UTF-8.
    	* time/strftime_l.c (f_altmonth): New macro.
    	(__strftime_internal): Handle %OB format.
    	* time/strptime_l.c [_LIBC] (alt_month_name): New macro.
    	(__strptime_internal): Handle %OB format.
    	* time/tst-strptime.c (day_tests): Add tests to parse different forms
    	of month names including the new %OB format specifier.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                        |   74 +++++++++++++++++++++++++
 NEWS                             |   24 ++++++++
 locale/C-time.c                  |   52 +++++++++++++++++-
 locale/categories.def            |    4 ++
 locale/langinfo.h                |   86 ++++++++++++++++++++++++++++--
 locale/programs/ld-time.c        |   40 ++++++++++++++
 locale/programs/locfile-kw.gperf |    2 +
 locale/programs/locfile-kw.h     |  112 ++++++++++++++++++++------------------
 locale/programs/locfile-token.h  |    2 +
 localedata/locales/pl_PL         |   14 +++++-
 localedata/tst-langinfo.c        |   12 ++++
 manual/locale.texi               |   26 ++++++++-
 manual/time.texi                 |   35 +++++++++---
 time/Makefile                    |    3 +-
 time/strftime_l.c                |   25 +++++++--
 time/strptime_l.c                |   50 ++++++++++++++++--
 time/tst-strptime.c              |   20 +++++++
 17 files changed, 500 insertions(+), 81 deletions(-)

Fixed with today's commits.  Still needs more locale data updates but they will be added as soon as the language communities show their interest.

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  86530b9fed4466a7c05e20ec4d5fd89b4dc41fa6 (commit)
      from  481306902f989d8eed0434eea3dcbebf6e609a95 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=86530b9fed4466a7c05e20ec4d5fd89b4dc41fa6

commit 86530b9fed4466a7c05e20ec4d5fd89b4dc41fa6
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Tue Jan 5 03:06:25 2016 +0100

    uk_UA: Add alternative month names (bug 10871).
    
    Primary month names are in a genitive case now, alternative month names
    are in a nominative case.
    
    The alternative digits hack is no longer needed and has been removed.
    
    	[BZ #10871]
    	* localedata/locales/uk_UA (mon): Renamed to...
    	(alt_mon): This.
    	(alt_digits): "0" removed and then renamed to...
    	(mon): This.
    	(date_fmt): Definition changed not to use the alternative
    	digits hack.

-----------------------------------------------------------------------

Summary of changes:
 localedata/locales/uk_UA |   18 +++++-------------
 1 files changed, 5 insertions(+), 13 deletions(-)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  8b406f8776d84d6697bca7d1da7bbfae6cfb8f85 (commit)
       via  105e90bd830bfd553773729690b1a71f36de345f (commit)
       via  561cb41473be080c4569c2bceae30b5301d15b89 (commit)
       via  f7bdf30d1549f9b9e7d47f5314215eeb7116c47f (commit)
      from  1f89ac719018bf7cd372c4f73aa067ced5f7ecd4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8b406f8776d84d6697bca7d1da7bbfae6cfb8f85

commit 8b406f8776d84d6697bca7d1da7bbfae6cfb8f85
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Mon Jan 29 13:00:43 2018 +0100

    lt_LT: Add alternative month names (bug 10871).
    
    	[BZ #10871]
    	* localedata/locales/lt_LT (alt_mon): Import from CLDR (nominative
    	case).

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=105e90bd830bfd553773729690b1a71f36de345f

commit 105e90bd830bfd553773729690b1a71f36de345f
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Sun Jan 28 01:23:45 2018 +0100

    be_BY, be_BY@latin: Add alternative month names (bug 10871).
    
    This patch also fixes spelling of lang_name in be_BY@latin, as reported
    by Ihar Hrachyshka.
    
    	[BZ #10871]
    	* localedata/locales/be_BY (mon): Rename to...
    	(alt_mon): This, then synchronize with CLDR (nominative case).
    	(abmon): Rename to...
    	(ab_alt_mon): This, then synchronize with CLDR (nominative case).
    	(mon): Import from CLDR (genitive case).
    	(abmon): Likewise.
    	* localedata/locales/be_BY@latin (mon): Rename to...
    	(alt_mon): This.
    	(mon): Add, proper genitive forms provided by Viktar Siarheichyk.
    
    	* localedata/locales/be_BY@latin (lang_name): Reworded to
    	"biełaruskaja mova".

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=561cb41473be080c4569c2bceae30b5301d15b89

commit 561cb41473be080c4569c2bceae30b5301d15b89
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Sat Jan 27 01:33:38 2018 +0100

    el_CY, el_GR: Add alternative month names (bug 10871).
    
    	[BZ #10871]
    	* localedata/locales/el_CY (mon): Renamed to...
    	(alt_mon): This.
    	(mon): Import from CLDR (genitive case).
    	* localedata/locales/el_GR: Likewise.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f7bdf30d1549f9b9e7d47f5314215eeb7116c47f

commit f7bdf30d1549f9b9e7d47f5314215eeb7116c47f
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Tue Jan 5 03:04:41 2016 +0100

    ru_RU, ru_UA: Add alternative month names (bug 10871).
    
    	[BZ #10871]
    	* localedata/locales/ru_RU (mon): Rename to...
    	(alt_mon): This.
    	(abmon): Rename to...
    	(ab_alt_mon): This.
    	(mon): Import from CLDR (genitive case).
    	(abmon): Copy from the old content except the 5th month which is
    	now in the genitive case, even when abbreviated.
    	* localedata/locales/ru_UA: Likewise.
    	* time/tst-strptime.c (day_tests): Add an actual example of
    	a difference between %b and %Ob in Russian.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                      |   44 ++++++++++++++++++++++++
 localedata/locales/be_BY       |   72 ++++++++++++++++++++++++++-------------
 localedata/locales/be_BY@latin |   16 ++++++++-
 localedata/locales/el_CY       |   14 +++++++-
 localedata/locales/el_GR       |   14 +++++++-
 localedata/locales/lt_LT       |   12 +++++++
 localedata/locales/ru_RU       |   28 ++++++++++++++-
 localedata/locales/ru_UA       |   28 ++++++++++++++-
 time/tst-strptime.c            |   12 ++++---
 9 files changed, 203 insertions(+), 37 deletions(-)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  9a1b267d470827ced2c81f6e711b5d5582a91a4d (commit)
      from  9a123ff05d624f429aa31fce10a8276a52a11f0d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9a1b267d470827ced2c81f6e711b5d5582a91a4d

commit 9a1b267d470827ced2c81f6e711b5d5582a91a4d
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Tue Jan 30 12:33:14 2018 +0100

    hr_HR: Add alternative month names (bug 10871).
    
    	[BZ #10871]
    	* localedata/locales/hr_HR (mon): Rename to...
    	(alt_mon): This.
    	(mon): Import from CLDR (genitive case).
    	(d_t_fmt): Update the comment.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                |    8 ++++++++
 localedata/locales/hr_HR |   16 ++++++++++++++--
 2 files changed, 22 insertions(+), 2 deletions(-)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  c10c9a5efedc11ec6e905571cf02d8f152a5761e (commit)
      from  650ba77ad547b24e0839c90ed56f7b9445d8165a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c10c9a5efedc11ec6e905571cf02d8f152a5761e

commit c10c9a5efedc11ec6e905571cf02d8f152a5761e
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Thu Feb 1 01:45:43 2018 +0100

    NEWS: List the languages which use the alternative months.
    
    	[BZ #10871]
    	* NEWS: List the languages which actually use the alternative
    	months feature in this release.  Also explain that "alt_mon" and
    	"ab_alt_mon" are optional.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog |    7 +++++++
 NEWS      |    9 ++++++++-
 2 files changed, 15 insertions(+), 1 deletions(-)

*** Bug 809 has been marked as a duplicate of this bug. ***

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  c4ad5782c44f4fa23d3ca9bec1e288c24cf2e6df (commit)
      from  ca121b117f2c9c97a4c121334481a96c94fef3a0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c4ad5782c44f4fa23d3ca9bec1e288c24cf2e6df

commit c4ad5782c44f4fa23d3ca9bec1e288c24cf2e6df
Author: Rafal Luzynski <digitalfreak@lingonborough.com>
Date:   Tue Jan 30 12:31:12 2018 +0100

    gd_GB, hsb_DE, wa_BE: Add alternative month names (bug 23140).
    
    As a followup of fixing bug 10871, these three languages now support two
    grammatical cases of the month names.
    
    This commit does not resolve the bug because there are more languages
    to be committed.
    
    	[BZ #23140]
    	* localedata/locales/gd_GB (mon): Rename to...
    	(alt_mon): This.
    	(mon): Import from CLDR (genitive case).
    	* localedata/locales/hsb_DE (mon): Rename to...
    	(alt_mon): This.
    	(mon): Import from CLDR (genitive case).
    	* localedata/locales/wa_BE (mon): Rename to...
    	(alt_mon): This.
    	(mon): Add, fill with the proper genitive forms, but CLDR data
    	is incomplete; completed according to the comments in this file.
    	(d_t_fmt): Do not use "di" before the month name, no longer needed.
    
    	* localedata/locales/wa_BE (country_name): Reword
    	"Beljike" -> "Beldjike".

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                 |   18 ++++++++++++++++++
 NEWS                      |    7 ++++---
 localedata/locales/gd_GB  |   17 ++++++++++++++++-
 localedata/locales/hsb_DE |   14 +++++++++++++-
 localedata/locales/wa_BE  |   24 ++++++++++++++++--------
 5 files changed, 67 insertions(+), 13 deletions(-)

The master branch has been updated by Rafal Luzynski <rl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2bd81b60d6ffdf7e0d22006d69f4b812b1c80513

commit 2bd81b60d6ffdf7e0d22006d69f4b812b1c80513
Author: Grzegorz Kulik <gregorykkulik@gmail.com>
Date:   Tue Jun 18 18:41:19 2019 +0200

    szl_PL locale: Spelling corrections (bug 24652).
    
    This commit also provides the correct month names in both nominative
    and genitive case for Silesian language, as required by the fix for
    the bug 10871.
    
    	[BZ #24652]
    	* localedata/locales/szl_PL (abday): Spelling corrections.
    	(day): Likewise.
    	(abmon): Likewise.
    	(mon): Rename to...
    	(alt_mon): This, then apply spelling corrections.
    	(mon): New entry, month names in the genitive case.