Bug 681

Summary: execl should use NULL not 0
Product: glibc Reporter: Marcus Meissner <meissner>
Component: libcAssignee: Roland McGrath <roland>
Status: RESOLVED FIXED    
Severity: normal CC: glibc-bugs
Priority: P2 Flags: fweimer: security-
Version: unspecified   
Target Milestone: ---   
Host: i686-pc-linux-gnu Target: i686-pc-linux-gnu
Build: i686-pc-linux-gnu Last reconfirmed:
Project(s) to access: ssh public key:
Bug Depends on:    
Bug Blocks: 724    
Attachments: ochild.pat

Description Marcus Meissner 2005-01-19 08:45:46 UTC
in sunrpc/openchild.c the closing tag of execl should be NULL instead of 0. 
 
see attached patch
Comment 1 Marcus Meissner 2005-01-19 08:46:28 UTC
Created attachment 377 [details]
ochild.pat

patch to fix problem
Comment 2 Andreas Jaeger 2005-01-19 09:12:35 UTC
Roland, shall I commit this?  It looks ok to me.
Comment 3 Sourceware Commits 2005-01-19 19:28:23 UTC
Subject: Bug 681

CVSROOT:	/cvs/glibc
Module name:	libc
Changes by:	roland@sources.redhat.com	2005-01-19 19:28:15

Modified files:
	sunrpc         : openchild.c 

Log message:
	2005-01-19  Roland McGrath  <roland@redhat.com>
	
	[BZ #681]
	* sunrpc/openchild.c (_openchild): Use NULL instead of 0 for trailing
	argument to execlp.
	Reported by Marcus Meissner <meissner@suse.de>.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sunrpc/openchild.c.diff?cvsroot=glibc&r1=1.6&r2=1.7

Comment 4 Roland McGrath 2005-01-19 19:29:21 UTC
This is fixed in the trunk now.  This report was filed for 2.3.4, but also for a
platform where this bug definitely has no effect.  If there is a practical
problem here, please cite it.
Comment 5 Marcus Meissner 2005-01-19 19:38:52 UTC
bugreport was meant for trunk, not for released branch. 
 
fine to mark as fixed now from my side. 
Comment 6 Roland McGrath 2005-01-19 19:54:01 UTC
Fixed now.
Comment 7 Sourceware Commits 2005-02-16 10:53:06 UTC
Subject: Bug 681

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-02-16 10:52:53

Modified files:
	sunrpc         : openchild.c 

Log message:
	2005-01-19  Roland McGrath  <roland@redhat.com>
	
	[BZ #681]
	* sunrpc/openchild.c (_openchild): Use NULL instead of 0 for trailing
	argument to execlp.
	Reported by Marcus Meissner <meissner@suse.de>.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sunrpc/openchild.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.6&r2=1.6.4.1