This is the mail archive of the
xconq7@sources.redhat.com
mailing list for the Xconq project.
Re: Compile Warnings
- From: Hans Ronne <hronne at comhem dot se>
- To: Jim Kingdon <kingdon at panix dot com>
- Cc: xconq7 at sources dot redhat dot com
- Date: Tue, 11 May 2004 00:44:46 +0200
- Subject: Re: Compile Warnings
- References: <1084152351.9540.17.camel@localhost.localdomain>
>> The bulk of the warnings originate in the bitmaps directory, and I am
>> not sure that we want to do anything about those ones.
>
>Well, the code really is bogus. It should be saying "unsigned char"
>but instead says "char". In practice it should be relatively
>portable, although I don't know about its legality in a language
>lawyer sense.
In fact, those unsigned chars were added two years ago, as part of the C++
compatibility patches:
2002-05-08 Hans Ronne <hronne@2.sbbs.se>
Add Ed Oskiewicz' C++ compatibility patches.
* (ants.b, attackcurs.b, attackmask.b, buildcurs.b, buildmask.b,
cursbord.b, curdsbordm.b, curscell.b, curscellm.b, curscoat.b,
curscoatm.b, cursconn.b, cursconnm.b, cursunit.b, cursunitm.b,
delay.b, dots.b, hex16iso.b, hex32iso.b, hex64.b, hex64b.b, hex64iso.b,
iso.b, laurels.b, lookglass.b, lookmask.b, reserve.b, return.b,
rotl.b, rotr.b,
scursdown.b, scursdownm.b, scursleft.b, scursleftm.b, scursright.b,
scursrightm.b, scursup.b, scursupm.b, shootcurs.b, shootmask.b,
sleep.b, wind0.b, wind1e.b, wind1ne.b, wind1nw.b, wind1se.b,
wind1sw.b, wind1w.b, wind2e.b, wind2ne.b, wind2nw.b, wind2se.b,
wind2sw.b, wind2w.b, wind3e.b, wind3ne.b, wind3nw.b, wind3se.b,
wind3sw.b, wind3w.b, wind4e.b, wind4ne.b, wind4nw.b, wind4se.b,
wind4sw.b, wind4w.b): Change unsigned char to char.
Now, if the choice is between ANSI pedantic code and C++ compatibility, I
would probably opt for the latter.
Hans