This is the mail archive of the xconq7@sources.redhat.com mailing list for the Xconq project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: emblem drawing glitches on linux


>The glitches were introduced by the checkin on 2003-05-01, which
>is mostly to do with unit views.  This checkin still covers a lot
>of code though, so is there anything I can do to narrow it down
>further?

Thanks, that was very useful information. Unfortunately, the new unit view
code was a major change all over the kernel and the interfaces, so it is
difficult to take it apart. However, for technical reasons I doubt that the
problem is with the unit view code itself. Rather, I suspect some other
changes thst were made at the same time. Two things come to mind:

1. There was a change in update_cell (end of tkmap.c) where an "erasing
row" now always is drawn if we see unit views instead of units and unit
names are shown on the map. What happens if you turn off unit names? Do you
still see the glitches? And what happens if you start the game with
see-all? Do they disappear then?

2. There weer also some changes to draw_current which draws the current
unit. What happens if you back out of these changes (if possible) so that
the unit view-specific code is bypassed? One way to achieve thtis is to
change line 3246 in tkmap.c from:

	if (vp->show_all) {

to:

	if (1) {

Hans



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]