Re: [PATCH 0/6] systemtap set of --sysroot option handling fixes

[David Smith <dsmith at redhat dot com>]

Victor,

I've checked in all your patches at this point. If anything still
doesn't work, please let me know.

In addition, I tried to add test cases for all the items you found in
commit c96dfba71:

<https://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commit;h=c96dfba71f882b6f3bfcc0a844c514e10d210fcc>

If you get a chance, I'd appreciate you looking it over and see if
there is anything else you think we should test.

Thanks again for all the patches!


On Mon, Mar 5, 2018 at 11:37 AM, Victor Kamensky <kamensky@cisco.com> wrote:
> Hi Folks,
>
> Here is set of fixes for SystemTap --sysroot option handling.
>
> Please look at individual patches decsription for issues observed and fixed.
>
> If commit messages are too details and big for SystemTap project
> guidelines feel free to trim them. Commit message structured in such
> way that text after "Here are steps how to reproduce the issue." could
> be removed if needed.
>
> I did not run full SystemTap regression with --sysroot option since SystemTap
> DejaGnu testsuites are not friendly to remote execution mode. I did run
> regular 'make installcheck' on the same baseline with and without changes
> and made sure that results are identical.
>
> If you would like to try stap in cross compiled environment with --sysroot
> option I've set up openembedded-core repository where these changes are
> integrated and since openembedded-core support virtual qemu based target
> for different CPU types stap with --sysroot option could be tested.
>
> Setup instructions are here:
>     https://github.com/victorkamensky/systemtap-oe-sysroot-manifest
>
> Victor Kamensky (6):
>   sysroot: fix short release -r option handling in case of sysroot read
>     System.map symbols
>   sysroot: fix short release -r option handling in case of sysroot pass
>     proper kernel modules
>   sysroot: debuginfo lookup with sysroot case do not remove sysroot from
>     file_name
>   sysroot: delay adding sysroot path to module name in case of non
>     absolute executable
>   sysroot: handle symbolic links with absolute name relative to sysroot
>   sysroot: _stp_umodule_relocate needs receive target file path
>
>  loc2stap.cxx  |  3 ++-
>  session.cxx   |  2 +-
>  setupdwfl.cxx | 28 ++++++++++------------
>  tapsets.cxx   |  8 +++----
>  util.cxx      | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 96 insertions(+), 21 deletions(-)
>
> --
> 2.14.3
>



-- 
David Smith
Associate Manager
Red Hat