This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Some newbie questions


On 08/26/2016 01:07 PM, David Smith wrote:
> --- a/tapset-utrace.cxx
> +++ b/tapset-utrace.cxx
> @@ -1208,6 +1208,12 @@ utrace_derived_probe_group::emit_module_linux_init (systemtap_session& s)
>      return;
>  
>    s.op->newline() << "/* ---- utrace probes ---- */";
> +  if (!flags_seen[UDPF_SYSCALL] && !flags_seen[UDPF_SYSCALL_RETURN])
> +    {
> +      s.op->newline() << "#if !defined(CONFIG_UTRACE)";
> +      s.op->newline() << "stap_utrace_only_vma_syscall_tracing();";
> +      s.op->newline() << "#endif";
> +    }

Will this be emitted if there are no utrace probes at all?

I think not, so perhaps the default should be flipped.  Assume filtered
syscalls by default, and let this code turn on the full mode if
process.syscall is in use.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]