Re: SystemTap for Android - patchset

[Alexander Lochmann <alexander dot lochmann at tu-dortmund dot de>]

On 06.07.2016 22:15, Frank Ch. Eigler wrote:
> Hi -
> 
> On Wed, Jul 06, 2016 at 10:05:23PM +0200, Alexander Lochmann wrote:
>> [...]
>>> % sh pidwrapper /path/to/this.pid staprun foo bar baz
>>>
>> That would be a nice workaround. I went through the source code. The
>> commandline option is used by stapio. Stapio creates the pidfile. If I
>> send a SIGKILL (or was it a SIGTERM? what so ever) to staprun, stap and
>> the module won't be shutdown properly. Hence, I have to send the signal
>> to stapio.
> 
> Since staprun exec's stapio, the latter will also share the same pid.
> So this wrapper would work, whichever process happens to be running at
> the moment.  (Send SIGTERM or SIGINT for a clean shutdown.)
> 
Indeed... strange. If I remember it correctly, I would say that wasn't
the case in that past. But git blame says something different.
Thus, I suppose it was my "fault". I thing I simply misinterpreted my
observations with "ps aux" back in that days. Anyway, I'll try your bash
wrapper. :-)

Do you have any concerns about the rest of my Android patch?
Namely the build script and those ifdefs in staprun.c.

- Alex
> 
> - FChE
> 


-- 
Technische Universität Dortmund
Alexander Lochmann                PGP key: 0xBC3EF6FD
Otto-Hahn-Str. 16                 phone:  +49.231.7556141
D-44227 Dortmund                  fax:    +49.231.7556116
http://ess.cs.tu-dortmund.de/Staff/al

Attachment: signature.asc
Description: OpenPGP digital signature