This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/3] add test cases for arith
- From: David Smith <dsmith at redhat dot com>
- To: Zhou, Wenjian/åæå <zhouwj-fnst at cn dot fujitsu dot com>, "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: systemtap at sourceware dot org
- Date: Wed, 9 Dec 2015 15:39:58 -0600
- Subject: Re: [PATCH 1/3] add test cases for arith
- Authentication-results: sourceware.org; auth=none
- References: <1449479119-10817-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com> <y0mio49yo2e dot fsf at fche dot csb> <5667F74D dot 2090305 at cn dot fujitsu dot com>
On 12/09/2015 03:41 AM, "Zhou, Wenjian/åæå" wrote:
> On 12/08/2015 11:09 PM, Frank Ch. Eigler wrote:
>>
>> Hi -
>>
>>
>> Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> writes:
>>
>>> * testsuite/systemtap.base/arith.stp: add more cases
>>> [...]
>>
>> I see nothing wrong with the proposed tests, but they seem to add very
>> little new coverage to the sorts of things thoroughly exercised
>> elsewhere. This set of arith.stp operator tests are probably OK, just
>> because we have their siblings there, but whitespace.stp IMHO doesn't
>> do anything special.
>>
>
> Hi Frank,
>
> The whitespace.stp tests that if the systemtap works well with white space
> and null statement(";").
> If you think it is not needed, I won't insist.
I've checked in the arith and map delete test changes. Thanks!
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)