This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/3] add test cases for arith
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Zhou Wenjian <zhouwj-fnst at cn dot fujitsu dot com>
- Cc: <systemtap at sourceware dot org>
- Date: Tue, 08 Dec 2015 10:09:29 -0500
- Subject: Re: [PATCH 1/3] add test cases for arith
- Authentication-results: sourceware.org; auth=none
- References: <1449479119-10817-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com>
Hi -
Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> writes:
> * testsuite/systemtap.base/arith.stp: add more cases
> [...]
I see nothing wrong with the proposed tests, but they seem to add very
little new coverage to the sorts of things thoroughly exercised
elsewhere. This set of arith.stp operator tests are probably OK, just
because we have their siblings there, but whitespace.stp IMHO doesn't
do anything special.
(By the way, there are also all kinds of other contributions worth
considering, be it documentation or bug or features fixes. We'd love
to mentor folks with any of these areas.)
- FChE