This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug tapsets/2111] document syscalls tapset


https://sourceware.org/bugzilla/show_bug.cgi?id=2111

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #14 from Josh Stone <jistone at redhat dot com> ---
1. The table would be a lot more useful if it were sorted by syscall name.

2. The "argstr" and "name" should be common to all syscall probes.  Let's
mention those in the intro section and filter them from the rest of the table. 
Might also mention "retstr" for syscall return probes.

3. Underscored names are most likely "private" locals, like the "__nr" that
frequently appears.  Let's filter them.

4. I think any differences between syscall and nd_syscall locals should be
considered bugs, not documented features.  But AFAICS the only differences
right now are underscored names -- see point 3.  So maybe we can report any
additional differences with a build-time warning, or even an error, but I don't
think they need any mention in the document.

5. (off-topic) That 15-page Table of Contents is kind of ridiculous IMO.  I'm
glad your syscall addition didn't get fully enumerated there too!  I think we
should probably reduce the TOC to just major section headings, and maybe add a
fuller index at the end of the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]