This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug tapsets/18571] Tapset support and test coverage for bpf and seccomp syscalls.
- From: "dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sourceware dot org
- Date: Wed, 24 Jun 2015 13:56:35 +0000
- Subject: [Bug tapsets/18571] Tapset support and test coverage for bpf and seccomp syscalls.
- Auto-submitted: auto-generated
- References: <bug-18571-6586 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=18571
--- Comment #2 from David Smith <dsmith at redhat dot com> ---
In general the patch looks fine to me. However, I'm not sure about this change:
====
- uargs = user_string_quoted($uargs)
+ uargs = $uargs
====
I think you are on the right path here, that is an address, not a string.
However, I think you should go a bit farther, deprecate the old string usage
and rename the convenience variable to 'uargs_uaddr' to make sure users know
this is a user address. The code would look something like:
====
%( systemtap_v <= "2.8" %?
uargs = user_string_quoted($uargs)
%)
uargs_uaddr = $uargs
====
You would also need to make changes when printing the argstr (using the new
variable name) and update the corresponding nd_syscall code.
--
You are receiving this mail because:
You are the assignee for the bug.