[Bug dyninst/17858] helloworld doesn't with --runtime=dyninst

["jistone at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17858

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #1 from Josh Stone <jistone at redhat dot com> ---
Clarified on IRC that fche has some -G options in his rc file.  So this stalls:

$ stap --runtime=dyninst .../helloworld.stp -G FOO=y
stapdyn: WARNING: Incorrect module option 'FOO=y'
[hang]

That comes from mutator::init_modoptions():

      int rc = global_setter(name.c_str(), value.c_str());
      if (rc != 0)
        {
          stapwarn() << "Incorrect module option '" << modoption << "'" <<
endl;
          return false; // XXX: perhaps ignore the option instead?
        }

This should either warn and continue, or error and exit.  For comparison, with
staprun you just get a warning in dmesg about ignoring the unknown module
option.

The "return false" actually does seem to indicate that it's trying to exit, but
this trickles up to mutator::run_module_init(), then to mutator::run(), where
it is ignored. :/

Then since the module's init never ran, we didn't get the begin probe at all,
so there's nothing else to cause the script to exit.  Thus it waits
forever......

-- 
You are receiving this mail because:
You are the assignee for the bug.