This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [Bug tapsets/13330] Support TRACE_SYSTEM for tracepoints
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: jlebon at redhat dot com
- Cc: systemtap at sourceware dot org
- Date: Tue, 06 Jan 2015 17:42:47 -0500
- Subject: Re: [Bug tapsets/13330] Support TRACE_SYSTEM for tracepoints
- Authentication-results: sourceware.org; auth=none
- References: <bug-13330-6586 at http dot sourceware dot org/bugzilla/> <bug-13330-6586-bfIwL8JeBi at http dot sourceware dot org/bugzilla/>
> --- Comment #2 from Jonathan Lebon <jlebon at redhat dot com> ---
> Added support for TRACE_SYSTEM in branch jlebon/trace_system:
> [...]
Looked the branch over briefly. The work looks sound and useful,
thank you!
(As an OOPS style nit, presence of both a public member variable and a
public member function to compute its initial/sole value, is a bit
odd. (tracepoint_query::current_system and ::retrieve_*). The
codebase is not exactly OOPS-pure, but if we can move toward it
slowly, that'd be good. e.g., initialize the variable during a ctor,
or from a private: function, or ... something. No big deal though.
- FChE