This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v2 0/3] initscript: add support for uprobes scripts
- From: Josh Stone <jistone at redhat dot com>
- To: Jonathan Lebon <jlebon at redhat dot com>, Stefan Hajnoczi <stefanha at redhat dot com>
- Cc: systemtap at sourceware dot org, fche at redhat dot com
- Date: Wed, 03 Sep 2014 16:22:33 -0700
- Subject: Re: [PATCH v2 0/3] initscript: add support for uprobes scripts
- Authentication-results: sourceware.org; auth=none
- References: <20140901121508 dot GA7855 at stefanha-thinkpad dot redhat dot com> <506323430 dot 41761582 dot 1409670206483 dot JavaMail dot zimbra at redhat dot com> <20140903124615 dot GK28095 at stefanha-thinkpad dot redhat dot com> <1623394325 dot 37775 dot 1409785309600 dot JavaMail dot zimbra at redhat dot com>
On 09/03/2014 04:01 PM, Jonathan Lebon wrote:
> BTW, while testing, I've noticed that --save-uprobes only has an
> effect if uprobes.ko was not already built and cached in a previous
> run. Have you encountered that as well?
>
> We may need to tweak the buildrun.cxx logic a bit if that's the
> case.
I'd guess that get_cached_uprobes() ought to set s.built_uprobes when it
assigns s.uprobes_path, just as make_uprobes() does.
Actually, I think s.built_uprobes may not be needed at all, just check
s.uprobes_path.empty().