This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/1] Adding enumeration support to statement pp
- From: Jonathan Lebon <jlebon at redhat dot com>
- To: BR Chrisman <brchrisman at gmail dot com>
- Cc: systemtap at sourceware dot org
- Date: Thu, 5 Jun 2014 10:21:19 -0400 (EDT)
- Subject: Re: [PATCH 1/1] Adding enumeration support to statement pp
- Authentication-results: sourceware.org; auth=none
- References: <1401915437-25266-1-git-send-email-brchrisman at gmail dot com> <CAN4=B2kvxeCQpFshyZAu3QhhVriqPJBLqmsMzrpTaVTOPQ8NHQ at mail dot gmail dot com>
Hi Brian,
Patch looks good! I committed it to the master branch (commit f01d4ff).
Thanks a lot for your contribution! :)
> I couldn't find the output generated from parse_function_spec, but I
> didn't get a segfault either, with/without -vv.
> Is there a particular command line form I can use to test this?
Ahhh, you just needed one more -v flag.
Try this:
stap -vvv -l 'kernel.statement("vfs_read@fs/read_write.c:381-383,389")' |& grep '^parse '
> Sadly, my two test cases still fail in my environment... I'm perplexed. :)
Strange, they all pass here.
Which ones are failing for you?
Cheers,
Jonathan