This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v8 16/26] ftrace/kprobes: Use NOKPROBE_SYMBOL macro in ftrace
- From: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- To: Steven Rostedt <rostedt at goodmis dot org>
- Cc: linux-kernel at vger dot kernel dot org, Ingo Molnar <mingo at kernel dot org>, Andi Kleen <andi at firstfloor dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, x86 at kernel dot org, fche at redhat dot com, mingo at redhat dot com, systemtap at sourceware dot org, "H. Peter Anvin" <hpa at zytor dot com>, Thomas Gleixner <tglx at linutronix dot de>
- Date: Tue, 25 Mar 2014 19:31:38 +0900
- Subject: Re: [PATCH -tip v8 16/26] ftrace/kprobes: Use NOKPROBE_SYMBOL macro in ftrace
- Authentication-results: sourceware.org; auth=none
- References: <20140305115843 dot 22766 dot 8355 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140305120035 dot 22766 dot 90265 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140324161025 dot 3f51bab6 at gandalf dot local dot home>
(2014/03/25 5:10), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:35 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>
>> -static __kprobes
>> +static
>> int kretprobe_dispatcher(struct kretprobe_instance *ri, struct pt_regs *regs)
>
> again, static and int should be on the same line.
OK, thank you! :)
>
>> {
>> struct trace_kprobe *tk = container_of(ri->rp, struct trace_kprobe, rp);
>> @@ -1268,6 +1279,7 @@ int kretprobe_dispatcher(struct kretprobe_instance *ri, struct pt_regs *regs)
>> #endif
>> return 0; /* We don't tweek kernel, so just return 0 */
>> }
>> +NOKPROBE_SYMBOL(kretprobe_dispatcher);
>>
>> static struct trace_event_functions kretprobe_funcs = {
>> .trace = print_kretprobe_event
>
> -- Steve
>
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com