This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path
- From: David Ahern <dsahern at gmail dot com>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Arnaldo Carvalho de Melo <acme at ghostprotocols dot net>
- Cc: Ingo Molnar <mingo at kernel dot org>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, lkml <linux-kernel at vger dot kernel dot org>, "Steven Rostedt (Red Hat)" <rostedt at goodmis dot org>, Oleg Nesterov <oleg at redhat dot com>, "David A. Long" <dave dot long at linaro dot org>, systemtap at sourceware dot org, yrl dot pp-manager dot tt at hitachi dot com, Namhyung Kim <namhyung at kernel dot org>
- Date: Fri, 27 Dec 2013 09:20:11 -0500
- Subject: Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path
- Authentication-results: sourceware.org; auth=none
- References: <20131226054148 dot 22364 dot 25224 dot stgit at kbuild-fedora dot novalocal> <20131226054150 dot 22364 dot 12187 dot stgit at kbuild-fedora dot novalocal> <52BC39D6 dot 3090908 at gmail dot com> <20131226142248 dot GE30980 at ghostprotocols dot net> <52BD1ACA dot 7030506 at hitachi dot com>
On 12/27/13, 1:14 AM, Masami Hiramatsu wrote:
Nowhere, since there is no terminal code for user
command interface.
Those memories are released when the program terminated.
I think it is just a waste of the time to free the memory
pieces which are not used(and allocated) repeatedly.
Or, is there any chance to call this part directly from
other command?
Most of the functionality has a destructor to clean up memory
allocations. probe code needs to follow suit.
e.g, from builtin-record.c:
err = __cmd_record(&record, argc, argv);
perf_evlist__munmap(evsel_list);
perf_evlist__close(evsel_list);
out_free_fd:
perf_evlist__delete_maps(evsel_list);
out_symbol_exit:
symbol__exit();
and __cmd_record ends by cleaning up the session struct.
David