This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v3 02/23] kprobes: Introduce NOKPROBE_SYMBOL() macro for blacklist
- From: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- To: Ingo Molnar <mingo at kernel dot org>
- Cc: linux-arch at vger dot kernel dot org, Jeremy Fitzhardinge <jeremy at goop dot org>, Rusty Russell <rusty at rustcorp dot com dot au>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Arnd Bergmann <arnd at arndb dot de>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, x86 at kernel dot org, lkml <linux-kernel at vger dot kernel dot org>, "Steven Rostedt (Red Hat)" <rostedt at goodmis dot org>, virtualization at lists dot linux-foundation dot org, Chris Wright <chrisw at sous-sol dot org>, Peter Zijlstra <peterz at infradead dot org>, Ingo Molnar <mingo at redhat dot com>, Thomas Gleixner <tglx at linutronix dot de>, Rob Landley <rob at landley dot net>, systemtap at sourceware dot org, "H. Peter Anvin" <hpa at zytor dot com>, Alok Kataria <akataria at vmware dot com>, "David S. Miller" <davem at davemloft dot net>
- Date: Thu, 28 Nov 2013 16:56:15 +0900
- Subject: Re: [PATCH -tip v3 02/23] kprobes: Introduce NOKPROBE_SYMBOL() macro for blacklist
- Authentication-results: sourceware.org; auth=none
- References: <20131120042148 dot 15296 dot 88360 dot stgit at kbuild-fedora dot novalocal> <20131120042153 dot 15296 dot 82087 dot stgit at kbuild-fedora dot novalocal> <20131127133224 dot GD18422 at gmail dot com>
(2013/11/27 22:32), Ingo Molnar wrote:
>
> * Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>> +#ifdef CONFIG_KPROBES
>> +/*
>> + * Blacklist ganerating macro. Specify functions which is not probed
>> + * by using this macro.
>> + */
>> +#define __NOKPROBE_SYMBOL(fname) \
>> +static struct kprobe_blackpoint __used \
>> + _kprobe_bp_##fname = { \
>> + .name = #fname, \
>> + .start_addr = (unsigned long)fname, \
>> + }; \
>> +static struct kprobe_blackpoint __used \
>> + __attribute__((section("_kprobe_blacklist"))) \
>> + *_p_kprobe_bp_##fname = &_kprobe_bp_##fname;
>
> 'kprobe_blackpoint' sounds a bit weird - how about
> 'kprobe_blacklist_entry' ?
OK, I just tried to reuse existed kprobe_blacklist.
> also, _kprobe_blacklist probably wants to be _kprobes_blacklist,
> right?
I sse. I'll update it. :)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com