This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] fix aggregate stats in mutex-contention example
- From: David Smith <dsmith at redhat dot com>
- To: Peter Feiner <peter at gridcentric dot ca>
- Cc: systemtap at sourceware dot org
- Date: Mon, 24 Jun 2013 13:16:02 -0500
- Subject: Re: [PATCH] fix aggregate stats in mutex-contention example
- References: <1369253067-13454-1-git-send-email-peter at gridcentric dot ca>
On 05/22/2013 03:04 PM, Peter Feiner wrote:
> Stats that were supposed to be collected per FUTEX_WAIT call site were being
> collected per mutex init stack. So, in the "aggregate stats" section of the
> report, you'd see a bunch of stacks with pthread_mutex_init at the top ... which
> was very confusing because a futex isn't contended when it's created :-)
I've checked your change in with the following commit.
====
commit 8f923ff46ae2f91ccea95737fca3524c861a553c
Author: Peter Feiner <peter@gridcentric.ca>
Date: Mon Jun 24 13:11:42 2013 -0500
Updated testsuite/systemtap.examples/process/mutex_contention.stp
example.
Stats that were supposed to be collected per FUTEX_WAIT call site were
being collected per mutex init stack. So, in the "aggregate stats"
section
of the report, you'd see a bunch of stacks with pthread_mutex_init
at the
top, which was very confusing because a futex isn't contended when it's
created.
====
Thanks for the update - sorry this response took so long.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)