This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] fixes for ENABLE_NLS=0
- From: Josh Stone <jistone at redhat dot com>
- To: groleo at gmail dot com
- Cc: systemtap at sourceware dot org, Adrian Marius Negreanu <adrian dot m dot negreanu at intel dot com>
- Date: Fri, 22 Mar 2013 10:19:00 -0700
- Subject: Re: [PATCH] fixes for ENABLE_NLS=0
- References: <1363941913-30981-1-git-send-email-groleo at gmail dot com>
On 03/22/2013 01:45 AM, groleo@gmail.com wrote:
> From: Adrian Marius Negreanu <adrian.m.negreanu@intel.com>
>
> tested by setting ENABLE_NLS to zero, inside config.h
Thanks - note you can use ./configure --disable-nls for the same effect.
> --- a/parse.cxx
> +++ b/parse.cxx
> @@ -592,7 +592,7 @@ parser::scan_pp1 ()
> if (! (t && t->type == tok_operator && t->content == "("))
> {
> delete new_act;
> - throw parse_error (_F(ngettext
> + throw parse_error (_F(_N
> ("expected '(' in invocation of macro '@%s'"
> " taking %d parameter",
> "expected '(' in invocation of macro '@%s'"
Eww, example like this are attempting to double-translate, regardless of
your change. We have _NF(format, format_plural, count, ...) which
should handle this correctly.
If you could correct those, then the rest of it looks fine to me.
Thanks,
Josh