This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug runtime/14389] sprintf not formatting "%#o" output properly


http://sourceware.org/bugzilla/show_bug.cgi?id=14389

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #1 from Josh Stone <jistone at redhat dot com> 2012-07-23 19:52:31 UTC ---
(In reply to comment #0)
> The "%#o" formatting string isn't handling the value of 0 properly.  '0' should
> be formatted as '0', not '00'.
[...]
> (This is causing a failure in the nd_syscall.exp testcase for umask, because
> the nd_syscall probe uses the 'returnstr' function, which uses the kernel's
> snprintf() function which correctly handles 0.)

Seems like just a difference of opinion to me.  We also print %#x,0 as 0x0,
which I know differs from glibc, but I'm not sure what the kernel does with
that.

We could just as well flip this that returnstr() ought to be using stap's own
formatting functions for consistency...

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]