This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 01/10] Correct and consistent .meta files for example


Signed-off-by: Fredrik Östman <fredrik_oestman@mentor.com>
---
 .../systemtap.examples/general/ansi_colors.meta    |    2 +-
 .../systemtap.examples/general/ansi_colors2.meta   |    2 +-
 testsuite/systemtap.examples/general/badname.meta  |    2 +-
 .../systemtap.examples/general/eventcount.meta     |    6 +++---
 .../general/func_time_stats.meta                   |   12 +++++++++---
 testsuite/systemtap.examples/general/graphs.meta   |    4 ++--
 .../systemtap.examples/general/helloworld.meta     |    2 +-
 .../general/para-callgraph-verbose.meta            |   10 ++++++++--
 .../systemtap.examples/general/para-callgraph.meta |   10 ++++++++--
 testsuite/systemtap.examples/general/sizeof.meta   |   11 +++++++++--
 testsuite/systemtap.examples/general/varwatch.meta |    9 ++++++++-
 testsuite/systemtap.examples/general/watchdog.meta |   10 ++++++++--
 12 files changed, 59 insertions(+), 21 deletions(-)

diff --git a/testsuite/systemtap.examples/general/ansi_colors.meta b/testsuite/systemtap.examples/general/ansi_colors.meta
index 2818c23..927c77c 100644
--- a/testsuite/systemtap.examples/general/ansi_colors.meta
+++ b/testsuite/systemtap.examples/general/ansi_colors.meta
@@ -6,7 +6,7 @@ keywords: format
 subsystem: none
 status: production
 exit: fixed
-output: text
+output: graph
 scope: system-wide
 description: The script prints a table showing the available color combinations for the ansi_set_color2() and ans_set_color3() functions in the ansi.stp tapset.
 test_check: stap -p4 ansi_colors.stp
diff --git a/testsuite/systemtap.examples/general/ansi_colors2.meta b/testsuite/systemtap.examples/general/ansi_colors2.meta
index 4ccaf4e..66e556f 100644
--- a/testsuite/systemtap.examples/general/ansi_colors2.meta
+++ b/testsuite/systemtap.examples/general/ansi_colors2.meta
@@ -6,7 +6,7 @@ keywords: format
 subsystem: none
 status: production
 exit: fixed
-output: text
+output: graph
 scope: system-wide
 description: The script prints a table showing the available attributes (bold, underline, and inverse) with color combinations for the ans_set_color3() function in the ansi.stp tapset.
 test_check: stap -p4 ansi_colors2.stp
diff --git a/testsuite/systemtap.examples/general/badname.meta b/testsuite/systemtap.examples/general/badname.meta
index 11c9c88..00e2ac3 100644
--- a/testsuite/systemtap.examples/general/badname.meta
+++ b/testsuite/systemtap.examples/general/badname.meta
@@ -1,7 +1,7 @@
 title: Bad Filename Filter
 name: badname.stp
 version: 1.0
-keywords: filesystem hack
+keywords: filesystem
 author: Josh Stone
 subsystem: filesystem
 status: experimental
diff --git a/testsuite/systemtap.examples/general/eventcount.meta b/testsuite/systemtap.examples/general/eventcount.meta
index c03ceab..5ab1e0d 100644
--- a/testsuite/systemtap.examples/general/eventcount.meta
+++ b/testsuite/systemtap.examples/general/eventcount.meta
@@ -1,12 +1,12 @@
-title: Event Counter for eventcount.stp
+title: Count Specified Events
 name: eventcount.stp
 version: 1.0
 author: Lukas Berk
-keywords: event counter tid pid
+keywords: statistics thread process
 subsystem: none
 status: production
 exit: user-controlled
-output: text
+output: batch on-exit
 scope: system-wide
 description: The script prints a count of specified events and their related tid's over the course of execution.
 test_check: stap -p4 eventcount.stp
diff --git a/testsuite/systemtap.examples/general/func_time_stats.meta b/testsuite/systemtap.examples/general/func_time_stats.meta
index 657c0ed..25e5a14 100644
--- a/testsuite/systemtap.examples/general/func_time_stats.meta
+++ b/testsuite/systemtap.examples/general/func_time_stats.meta
@@ -1,7 +1,13 @@
-title: Function time statistics
+title: Function Time Statistics
 name: func_time_stats.stp
-keywords: function wall-clock time
-subsystem: general
+version: 1.0
+author: anonymous
+keywords: function statistics
+subsystem: any
+status: proposed
+exit: user-controlled
+output: histogram on-exit
+scope: system-wide
 description: The func_time_stats.stp script tracks the wall clock time for each invocation of the function probe listed as the first command line argument. When the script exits it prints out the minimum, average, and maximum times in microseconds followed by a count of times that the function was called and a histogram showing the distributions of times.
 test_check: stap -p4 func_time_stats.stp 'syscall.nanosleep'
 test_installcheck: stap func_time_stats.stp 'syscall.nanosleep' -c "sleep 0.2"
diff --git a/testsuite/systemtap.examples/general/graphs.meta b/testsuite/systemtap.examples/general/graphs.meta
index 273162e..8653247 100644
--- a/testsuite/systemtap.examples/general/graphs.meta
+++ b/testsuite/systemtap.examples/general/graphs.meta
@@ -2,11 +2,11 @@ title: Graphing Disk and CPU Utilization
 name: graphs.stp
 version: 1.0
 author: anonymous
-keywords: disk cpu use graph
+keywords: disk cpu utilization
 subsystem: disk cpu
 status: production
 exit: user-controlled
-output: plot data
+output: graph
 scope: system-wide
 description: The script tracks the disk and CPU utilization. The resulting output of the script can be piped into gnuplot to generate a graph of disk and CPU USE.
 test_check: stap -p4 graphs.stp
diff --git a/testsuite/systemtap.examples/general/helloworld.meta b/testsuite/systemtap.examples/general/helloworld.meta
index 60bc53f..a8a244d 100644
--- a/testsuite/systemtap.examples/general/helloworld.meta
+++ b/testsuite/systemtap.examples/general/helloworld.meta
@@ -6,7 +6,7 @@ author: anonymous
 subsystem: none
 status: production
 exit: fixed
-output: text
+output: trace
 scope: system-wide
 description: A basic "Hello World" program implemented in SystemTap script. It prints out "hello world" message and then immediately exits.
 test_check: stap -p4 helloworld.stp
diff --git a/testsuite/systemtap.examples/general/para-callgraph-verbose.meta b/testsuite/systemtap.examples/general/para-callgraph-verbose.meta
index 1a717a3..07e6427 100644
--- a/testsuite/systemtap.examples/general/para-callgraph-verbose.meta
+++ b/testsuite/systemtap.examples/general/para-callgraph-verbose.meta
@@ -1,7 +1,13 @@
-title: Callgraph tracing with verbose arguments
+title: Callgraph Tracing with Verbose Arguments
 name: para-callgraph-verbose.stp
+version: 1.0
+author: anonymous
 keywords: trace callgraph
-subsystem: general
+subsystem: any
+status: proposed
+exit: user-controlled
+output: trace
+scope: system-wide
 description: Print a timed per-thread callgraph, complete with pretty-printed function parameters and return values.  The first parameter names the function probe points to trace.  The optional second parameter names the probe points for trigger functions, which acts to enable tracing for only those functions that occur while the current thread is nested within the trigger.
 test_check: stap -p4 para-callgraph-verbose.stp 'kernel.function("*@fs/proc*.c")' 'kernel.function("vfs_read")'
 test_installcheck: stap para-callgraph-verbose.stp 'kernel.function("*@fs/proc*.c")' 'kernel.function("vfs_read")' -c "cat /proc/sys/vm/* || true"
diff --git a/testsuite/systemtap.examples/general/para-callgraph.meta b/testsuite/systemtap.examples/general/para-callgraph.meta
index c346574..0b3ff2d 100644
--- a/testsuite/systemtap.examples/general/para-callgraph.meta
+++ b/testsuite/systemtap.examples/general/para-callgraph.meta
@@ -1,7 +1,13 @@
-title: Callgraph tracing with arguments
+title: Callgraph Tracing with Arguments
 name: para-callgraph.stp
+version: 1.0
+author: anonymous
 keywords: trace callgraph
-subsystem: general
+subsystem: any
+status: proposed
+exit: user-controlled
+output: trace
+scope: system-wide
 description: Print a timed per-thread callgraph, complete with function parameters and return values.  The first parameter names the function probe points to trace.  The optional second parameter names the probe points for trigger functions, which acts to enable tracing for only those functions that occur while the current thread is nested within the trigger.
 test_check: stap -p4 para-callgraph.stp 'kernel.function("*@fs/proc*.c")' 'kernel.function("vfs_read")'
 test_installcheck: stap para-callgraph.stp 'kernel.function("*@fs/proc*.c")' 'kernel.function("vfs_read")' -c "cat /proc/sys/vm/* || true"
diff --git a/testsuite/systemtap.examples/general/sizeof.meta b/testsuite/systemtap.examples/general/sizeof.meta
index 5d78050..34e5e5f 100644
--- a/testsuite/systemtap.examples/general/sizeof.meta
+++ b/testsuite/systemtap.examples/general/sizeof.meta
@@ -1,6 +1,13 @@
-title: Print the size of a C type.
+title: Print the Size of a C Type
 name: sizeof.stp
-keywords: statistics memory simple
+version: 1.0
+author: anonymous
+keywords: statistics memory
+subsystem: any
+status: proposed
+exit: event-ended
+output: on-exit
+scope: system-wide
 description: This script prints the size of a type, based on dwarf debuginfo for any kernel or userspace module, or trial-compilation of a given header file name.
 test_check: stap -p4 sizeof.stp task_struct 'kernel:<include/linux/sched.h>'
 test_installcheck: stap sizeof.stp FILE '</usr/include/stdio.h>'
diff --git a/testsuite/systemtap.examples/general/varwatch.meta b/testsuite/systemtap.examples/general/varwatch.meta
index 3d876bb..788b486 100644
--- a/testsuite/systemtap.examples/general/varwatch.meta
+++ b/testsuite/systemtap.examples/general/varwatch.meta
@@ -1,6 +1,13 @@
-title: Watch a variable changing value in a thread.
+title: Watch a Variable Changing Value in a Thread
 name: varwatch.stp
+version: 1.0
+author: anonymous
 keywords: monitoring
+subsystem: any
+status: proposed
+exit: user-controlled
+output: trace
+scope: system-wide
 description: This script places a set of probes (specified by $1), each of which monitors the state of some context $variable expression (specified by $2).  Whenever the value changes, with respect to the active thread, the event is traced.
 test_check: stap -wp4 varwatch.stp 'kernel.statement("do_sys_open@fs/open.c:*")' '$$vars'
 test_installcheck: stap -w varwatch.stp 'kernel.statement("do_sys_open@fs/open.c:*")' '$$vars' -c "sleep 0.2"
diff --git a/testsuite/systemtap.examples/general/watchdog.meta b/testsuite/systemtap.examples/general/watchdog.meta
index f17df3e..5c2da3e 100644
--- a/testsuite/systemtap.examples/general/watchdog.meta
+++ b/testsuite/systemtap.examples/general/watchdog.meta
@@ -1,7 +1,13 @@
-title: Watchdog timer
+title: Watchdog Timer for Arbitrary Events
 name: watchdog.stp
+version: 1.0
+author: anonymous
 keywords: watchdog backtrace
-subsystem: general
+subsystem: any
+status: proposed
+exit: user-controlled
+output: on-exit
+scope: system-wide
 description: The watchdog.stp script provides a watchdog timer mechanism for arbitrary events. The script takes three arguments: the events to start watchdog timer, the event to stop the watchdog timer, and the time in millseconds for the watchdog. If the watchdog timer is exceed, the script will trigger a stack backtrace of the user-process that timed out using pstack. This script can be used to diagnose what the userspace application is doing when a slower than expected operation occurs.
 test_support: which /usr/bin/pstack
 test_check: stap -p4 watchdog.stp 'syscall.nanosleep' 'syscall.nanosleep.return' 1000
-- 
1.7.6.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]