This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug kprobes/13108] kprobing some paravirt stuff seems unsafe


http://sourceware.org/bugzilla/show_bug.cgi?id=13108

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #2 from Josh Stone <jistone at redhat dot com> 2011-08-18 21:31:50 UTC ---
(In reply to comment #1)
> The patch in comment #1 doesn't seem to prevent setting a probe on
> kernel.function("clts"), so it is wrong, haven't figured out why yet though.

Ugh -- I think you've uncovered another bug, that blfile probably shouldn't be
^-anchored at the start.  I get:

> $ stap -l 'kernel.function("*@paravirt*.c")' | wc -l
> 0
> $ stap -l 'kernel.function("*@paravirt*.h")' | wc -l
> 93
> $ stap -l 'kernel.function("clts")'
> kernel.function("clts@/usr/src/debug/kernel-2.6.39.fc15/linux-2.6.39.x86_64/arch/x86/include/asm/paravirt.h:47")

It looks like all #include <asm/*> files are showing a full path, thus we
shouldn't expect to match the leading portions at all.  Either those specific
asm paths need a ".*" in front, or we can remove the "^" from blfile
altogether.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]