This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v3 2.6.39-rc1-tip 7/26] 7: x86: analyze instruction and determine fixups.
- From: Peter Zijlstra <peterz at infradead dot org>
- To: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
- Cc: Steven Rostedt <rostedt at goodmis dot org>, Ingo Molnar <mingo at elte dot hu>, Linux-mm <linux-mm at kvack dot org>, Arnaldo Carvalho de Melo <acme at infradead dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, Andi Kleen <andi at firstfloor dot org>, Christoph Hellwig <hch at infradead dot org>, Jonathan Corbet <corbet at lwn dot net>, Thomas Gleixner <tglx at linutronix dot de>, Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Oleg Nesterov <oleg at redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>, SystemTap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at linux dot vnet dot ibm dot com>, Roland McGrath <roland at hack dot frob dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Andrew Morton <akpm at linux-foundation dot org>
- Date: Thu, 21 Apr 2011 19:52:25 +0200
- Subject: Re: [PATCH v3 2.6.39-rc1-tip 7/26] 7: x86: analyze instruction and determine fixups.
- References: <20110401143223.15455.19844.sendpatchset@localhost6.localdomain6> <20110401143348.15455.68644.sendpatchset@localhost6.localdomain6> <1303219751.7181.101.camel@gandalf.stny.rr.com> <20110421173120.GJ10698@linux.vnet.ibm.com>
On Thu, 2011-04-21 at 23:01 +0530, Srikar Dronamraju wrote:
>
> Sometimes, the user might try registering a probe at a valid file +
> valid offset + valid consumer; but an instruction that we cant probe.
> Then trying to figure why its failing would be very hard.
Uhm, how about failing to create the probe to begin with?
You can even do that in userspace as you can inspect the DSO you're
going to probe (and pretty much have to, since you'll have to pass the
kernel a fd to hand it the proper inode).