This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: tcpmib.InSeg probe point needs some default functions
- From: David Smith <dsmith at redhat dot com>
- To: William Cohen <wcohen at redhat dot com>
- Cc: SystemTAP <systemtap at sources dot redhat dot com>
- Date: Mon, 12 Jul 2010 08:50:45 -0500
- Subject: Re: tcpmib.InSeg probe point needs some default functions
- References: <4C37903A.3090702@redhat.com>
On 07/09/2010 04:10 PM, William Cohen wrote:
> I was looking through the test results for the systemtap.examples and found that following command used to determine whether the test should run doesn't work for systemtap.examples/network/tcpipstat.stp:
>
> stap -l 'tcpmib.InSegs'
>
> Looking through the tapset found that it expect a couple functions to be available. The attached patch adds those functions in a separate file so the user can overide the functions. If there are no objects about the patch I will check it in.
>
> Include default tcpmib_filter_key and ipmib_filter_key functions in tapset
>
> The tcpmib.InSegs probe point in the tcpmib.stp tapset makes uses
> of the tcpmib_filter_key() and the ipmib_filter_key() functions.
> Without these default functions the "stap -l 'tcpmib.InSegs'"
> command does not work.
Hmm, looking at your patch I wonder if it makes more sense to separate
those functions, 1 per file. Could there be a time when you'd want the
1 default function but want to override the other function?
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)