This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/1] Add environment variable fetching for current process


On 06/02/2010 06:08 PM, Lars R. Damerow wrote:
> Here's a patch to add environment variable fetching for the current process.
> It's heavily based on the existing context tapset functions for querying the
> process command line.

This looks good, but I made a small tweak:

> +          if (len > 0)
> +            env_value = tokenize("", "=");

If the actual value happens to have "=" in it, we don't want to truncate
it.  Using a "" delimiter instead lets us grab the entire remaining string.

Thanks!

Josh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]