This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 0/1] Add environment variable fetching for current process
- From: Josh Stone <jistone at redhat dot com>
- To: "Lars R. Damerow" <lars at pixar dot com>
- Cc: systemtap at sources dot redhat dot com
- Date: Wed, 02 Jun 2010 19:19:39 -0700
- Subject: Re: [PATCH 0/1] Add environment variable fetching for current process
- References: <1275527295-4052-1-git-send-email-lars@pixar.com>
On 06/02/2010 06:08 PM, Lars R. Damerow wrote:
> Here's a patch to add environment variable fetching for the current process.
> It's heavily based on the existing context tapset functions for querying the
> process command line.
This looks good, but I made a small tweak:
> + if (len > 0)
> + env_value = tokenize("", "=");
If the actual value happens to have "=" in it, we don't want to truncate
it. Using a "" delimiter instead lets us grab the entire remaining string.
Thanks!
Josh