This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v2 1/5] [BUGFIX] kprobes: Fix selftest to clear flags field for reusing probes
- From: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, lkml<linux-kernel at vger dot kernel dot org>, systemtap<systemtap at sources dot redhat dot com>, DLE<dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, Jason Baron <jbaron at redhat dot com>, Mathieu Desnoyers <mathieu dot desnoyers at efficios dot com>
- Date: Wed, 19 May 2010 10:32:46 +0530
- Subject: Re: [PATCH -tip v2 1/5] [BUGFIX] kprobes: Fix selftest to clear flags field for reusing probes
- References: <20100518201244.6058.73083.stgit@localhost6.localdomain6> <20100518201251.6058.60749.stgit@localhost6.localdomain6>
- Reply-to: ananth at in dot ibm dot com
On Tue, May 18, 2010 at 04:12:51PM -0400, Masami Hiramatsu wrote:
> kernel/test_kprobes.c | 12 +++++++++---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/test_kprobes.c b/kernel/test_kprobes.c
> index 4f10451..ede20f4 100644
> --- a/kernel/test_kprobes.c
> +++ b/kernel/test_kprobes.c
> @@ -115,7 +115,9 @@ static int test_kprobes(void)
> int ret;
> struct kprobe *kps[2] = {&kp, &kp2};
>
> - kp.addr = 0; /* addr should be cleard for reusing kprobe. */
> + /* addr and flags should be cleard for reusing kprobe. */
> + kp.addr = 0;
kp.addr = NULL;
> + kp.flags = 0;
> ret = register_kprobes(kps, 2);
> if (ret < 0) {
> printk(KERN_ERR "Kprobe smoke test failed: "
> @@ -210,7 +212,9 @@ static int test_jprobes(void)
> int ret;
> struct jprobe *jps[2] = {&jp, &jp2};
>
> - jp.kp.addr = 0; /* addr should be cleard for reusing kprobe. */
> + /* addr and flags should be cleard for reusing kprobe. */
> + jp.kp.addr = 0;
Same here...
> + jp.kp.flags = 0;
> ret = register_jprobes(jps, 2);
> if (ret < 0) {
> printk(KERN_ERR "Kprobe smoke test failed: "
> @@ -323,7 +327,9 @@ static int test_kretprobes(void)
> int ret;
> struct kretprobe *rps[2] = {&rp, &rp2};
>
> - rp.kp.addr = 0; /* addr should be cleard for reusing kprobe. */
> + /* addr and flags should be cleard for reusing kprobe. */
> + rp.kp.addr = 0;
Here too.
Ananth