This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v3 04/10] perf probe: Query basic types from debuginfo
- From: Arnaldo Carvalho de Melo <acme at redhat dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Paul Mackerras <paulus at samba dot org>, Peter Zijlstra <peterz at infradead dot org>, Mike Galbraith <efault at gmx dot de>, Frederic Weisbecker <fweisbec at gmail dot com>
- Date: Mon, 12 Apr 2010 14:45:08 -0300
- Subject: Re: [PATCH -tip v3 04/10] perf probe: Query basic types from debuginfo
- References: <20100412171646.3790.64715.stgit@localhost6.localdomain6> <20100412171715.3790.23730.stgit@localhost6.localdomain6>
Em Mon, Apr 12, 2010 at 01:17:15PM -0400, Masami Hiramatsu escreveu:
> Query the basic type information (byte-size and signed-flag) from
> debuginfo and pass that to kprobe-tracer. This is especially useful
> for tracing the members of data structure, because each member has
> different byte-size on the memory.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> ---
>
> tools/perf/util/probe-event.c | 9 +++++
> tools/perf/util/probe-event.h | 1 +
> tools/perf/util/probe-finder.c | 78 ++++++++++++++++++++++++++++++++++++----
> 3 files changed, 80 insertions(+), 8 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 19de8b7..05ca4a9 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -740,6 +740,13 @@ static int synthesize_kprobe_trace_arg(struct kprobe_trace_arg *arg,
> buf += ret;
> buflen -= ret;
> }
> + /* Print argument type */
> + if (arg->type) {
> + ret = e_snprintf(buf, buflen, ":%s", arg->type);
> + if (ret <= 0)
> + return ret;
> + buf += ret;
> + }
>
> return buf - tmp;
> }
> @@ -848,6 +855,8 @@ void clear_kprobe_trace_event(struct kprobe_trace_event *tev)
> free(tev->args[i].name);
> if (tev->args[i].value)
> free(tev->args[i].value);
> + if (tev->args[i].type)
> + free(tev->args[i].type);
It follows the existing style but as kfree, free() also can cope with
NULL pointers, so unconditionally calling free is a shorter form, but
this can be fixed later, possibily in a big cleanup in all of
tools/perf.
- Arnaldo