This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 0/8] perf-probe updates
- From: Ingo Molnar <mingo at elte dot hu>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Frederic Weisbecker <fweisbec at gmail dot com>, lkml <linux-kernel at vger dot kernel dot org>, Steven Rostedt <rostedt at goodmis dot org>, Jim Keniston <jkenisto at us dot ibm dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Christoph Hellwig <hch at infradead dot org>, "Frank Ch. Eigler" <fche at redhat dot com>, Jason Baron <jbaron at redhat dot com>, "K.Prasad" <prasad at linux dot vnet dot ibm dot com>, Peter Zijlstra <peterz at infradead dot org>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, Arnaldo Carvalho de Melo <acme at redhat dot com>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>
- Date: Wed, 9 Dec 2009 08:22:20 +0100
- Subject: Re: [PATCH -tip 0/8] perf-probe updates
- References: <20091208220232.10142.2643.stgit@dhcp-100-2-132.bos.redhat.com>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Hi Ingo,
>
> I made several usability updates and added --del option
> for perf-probe. I think most of basic functions are implemented.
> I'm planning to support checking build-id next, because it
> can prevent users to use old vmlinux for debuginfo analysis.
>
> Here are the todo list I have (most of them had been requested
> on LKML). I'd like to share this list with other developers
> who are interested in.
>
> Short-term TODOs:
> - Support checking kernel Build-ID
>
> Long-term TODOs (future features):
> - Support --line option to show which lines user can probe
> - Support lazy string matching(glob?) for selecting probing
> line
> - Support sys_perf_counter_open (for non-root users)
> - Support tracing static variables (non global)
> - Support variable types from debuginfo (e.g. char, int, ...)
> - Support fields of data structures (var->field)
> - Support array (var[N])
> - Support dynamic array-indexing (var[var2])
> - Support string/dynamic arrays (*var, var[N..M])
> - Support force type-casting ((type)var)
> - Support the type of return value
>
> Miscs:
> - Support glob expression with --del option (like --del "*")
> - Support event/group name specifying for new events
> - Better support for probes on modules
> - Symbol search by libelf/kallsyms
> - Move onto libdw/libdwfl
> - Storing file name/line number information in the
> kernel for listing events
>
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (8):
> perf probe: Update perf-probe document
> perf probe: Support --del option
> trace-kprobe: Support delete probe syntax
> perf probe: Support vmlinux on cwd by default
> perf probe: Remove event suffix number _0
> perf probe: Fix add-probe command syntax without --add option
> perf probe: Change probe-added message more user-friendly
> perf probe: Change event list format
>
>
> kernel/trace/trace_kprobe.c | 37 +++++++--
> tools/perf/Documentation/perf-probe.txt | 21 ++++-
> tools/perf/builtin-probe.c | 76 ++++++++++++++++---
> tools/perf/util/probe-event.c | 122 ++++++++++++++++++++++++++++---
> tools/perf/util/probe-event.h | 1
> 5 files changed, 217 insertions(+), 40 deletions(-)
Applied - thanks Masami!
These are very nice enhancements. I tried out the new features and they
worked well, and the use of the tool is intuitive.
One hickup is that -d/--del does not appear to be working yet:
# perf probe -l
probe:schedule (on schedule)
# perf probe -d probe:schedule
Fatal: Failed to write event: Invalid argument
Ingo