This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH V5] Tracepoint Tapset for Memory Subsystem


On Fri, Dec 04, 2009 at 12:11:33PM -0500, David Smith wrote:
> One really minor comment below.
> 
> > ----- Original Message -----
> > From: "Rajasekhar Duddu" <rajduddu@linux.vnet.ibm.com>
> > To: systemtap@sources.redhat.com
> > Sent: Friday, December 4, 2009 6:08:19 AM GMT -06:00 US/Canada Central
> > Subject: Re: [PATCH V5] Tracepoint Tapset for Memory Subsystem
> > 
> > 
> > Hi all,
> > 	I have update the patch according to Franks previous
> > comments.
> > Please review it and if it is fine, please somebody commit this
> > version of patch on behalf of me..thanks in advance.
> > 
> > 
> > +probe __vm.kmalloc.tp = kernel.trace("kmalloc") {
> > +	name = "kmalloc"
> > +	call_site = $call_site
> > +	caller_function = symname(call_site)
> > +	bytes_req = $bytes_req
> > +	bytes_alloc = $bytes_alloc
> > +	gfp_flags = $gfp_flags
> > +	gfp_flag_name = __gfp_flag_str($gfp_flags)
> > +	ptr = $ptr
> > +}
> > +
> > +/* It is unsafe to invoke __builtin_return_address() \
> > +presently(to get call_site for kporbe based probes) \
> > +and that it can be improved later when fix for bugs bz#6961 and bz#6580 is available. */
> 
> Typo here - 'kporbe' should be 'kprobe'.
> 
Thanks David, 
	I will correct it in my next patch.

-- 
Rajasekhar Duddu (rajduddu@linux.vnet.ibm.com),
Linux on System z - CSVT, IBM LTC, Bangalore.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]