This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/4] powerpc: Fix thinko in _stp_arg()
- From: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>
- To: Anton Vorontsov <avorontsov at ru dot mvista dot com>
- Cc: systemtap at sourceware dot org, Jim Keniston <jkenisto at us dot ibm dot com>, linuxppc-dev at ozlabs dot org
- Date: Fri, 4 Dec 2009 09:51:44 +0530
- Subject: Re: [PATCH 1/4] powerpc: Fix thinko in _stp_arg()
- References: <20091203233059.GA28186@oksana.dev.rtsoft.ru> <20091203233151.GA3416@oksana.dev.rtsoft.ru>
- Reply-to: ananth at in dot ibm dot com
On Fri, Dec 04, 2009 at 02:31:51AM +0300, Anton Vorontsov wrote:
> _stp_arg() has an almost unnoticeable thinko in the argnum handling,
> which causes it to always return u_register("r10"):
>
> 'else (argnum == 8)' should actually be 'else if (argnum == 8)'.
>
> Though, since we check for 'if (argnum < 1 || argnum > 8)' at the
> beginning of _stp_arg(), let's make it just 'else'.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Ugh! What was I thinking?
Thanks for fixing this Anton.
Ananth