This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip perf/probes 00/10] x86 insn decoder bugfixes and perf-probe syntax changes
- From: Masami Hiramatsu <mhiramat at redhat dot com>
- To: Ingo Molnar <mingo at elte dot hu>
- Cc: Arnaldo Carvalho de Melo <acme at redhat dot com>, Frédér ic Weisbecker <fweisbec at gmail dot com>, lkml <linux-kernel at vger dot kernel dot org>, Steven Rostedt <rostedt at goodmis dot org>, Jim Keniston <jkenisto at us dot ibm dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Christoph Hellwig <hch at infradead dot org>, "Frank Ch. Eigler" <fche at redhat dot com>, "H. Peter Anvin" <hpa at zytor dot com>, Jason Baron <jbaron at redhat dot com>, "K.Prasad" <prasad at linux dot vnet dot ibm dot com>, Peter Zijlstra <peterz at infradead dot org>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>
- Date: Mon, 02 Nov 2009 16:16:25 -0500
- Subject: Re: [PATCH -tip perf/probes 00/10] x86 insn decoder bugfixes and perf-probe syntax changes
- References: <20091027204156.30545.96425.stgit@harusame> <20091029085348.GD26970@elte.hu> <4AE9C919.4070003@redhat.com>
Masami Hiramatsu wrote:
Ingo Molnar wrote:
What we want here is two fold:
- enable kprobes event support when perf events is enabled and kprobes
is enabled. We dont want another config option for it.
Sure, at least that combination should enable kprobe-tracer forcibly.
Hmm, someone may not want to enables kprobe-tracer. Perhaps,
"default y if (EVENT_PROFILE)" is enough, isn't it?
A few further (and very small) UI tweaks i'd suggest:
Firstly, could we please make the first probe inserted named plain after
the symbol it specifies, with no _0 postfix? I.e. instead of:
7358 perfprobe:__switch_to_0 # 0.000 M/sec
we'd get:
7358 perfprobe:__switch_to # 0.000 M/sec
Subsequent probes for the same symbol can be named _1, _2 - but the
first symbol should not have this needless post-fix.
Ah, this prefix means the offset from the symbol. Of course we can
remove it if the offset == 0. Or, would you think make the postfix
sequence number of probes on the same symbol?
If so, we'd better have --list option before that and check the
postfix is already used, since we may not want to overwrite
existing probes, right?
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com