Re: [PATCH] A new testcase for tty tapset

[David Smith <dsmith at redhat dot com>]

In general the tapset and testcase look fine, but I have a few comments
about missing variables.  Also, it might help if the testcase probes
were in the same order as the tapset probes.

On 10/02/2009 04:02 PM, leitao@linux.vnet.ibm.com wrote:
> From: root <root@devhv4e-phantom-lp3.austin.ibm.com>
> 
> This is a basic test to assure that the tty tapset is working
> compiling and working properly
> ---
>  testsuite/buildok/tty.stp |   37 +++++++++++++++++++++++++++++++++++++
>  1 files changed, 37 insertions(+), 0 deletions(-)
>  create mode 100755 testsuite/buildok/tty.stp
> 
> diff --git a/testsuite/buildok/tty.stp b/testsuite/buildok/tty.stp
> new file mode 100755
> index 0000000..73f8706
> --- /dev/null
> +++ b/testsuite/buildok/tty.stp
> @@ -0,0 +1,37 @@
> +#! stap -wp4
> +
> +probe tty.poll{
> +	printf("Pooling tty %s for wait queue key %d\n", file_name, wait_key);
> +}
> +
> +probe tty.register {
> +	printf("Device registered using index %d using driver %s(%s)\n", index, driver_name, name)
> +}

Could you add module here?

> +probe tty.unregister {
> +	printf("Device registred using index %d using driver %s(%s)\n", index, driver_name, name)
> +}

Could you add module here?

> +
> +probe tty.release {
> +	printf("Closing file %s\n", file_name)
> +	printf("INODE: number %d\nState: %d\nFlag: %d\n", inode_number, inode_state, inode_flags)
> +	printf("File: %s mode %x flags %x\n", file_name, file_mode, file_flags)
> +}
> +
> +probe tty.open {
> +	printf("Opening tty file %s\n", file_name)
> +	printf("INODE: number %d\nState: %d\nFlag: %d\n", inode_number, inode_state, inode_flags)
> +	printf("File: %s mode %x flags %x\n", file_name, file_mode, file_flags)
> +}
> +
> +probe tty.resize {
> +	printf("Resizing %s from %dx%d to %dx%d\n", name, old_row, old_col, new_row, new_col)
> +}

Could you add old_ypixel, old_xpixel, new_ypixel, and new_xpixel here?

> +probe tty.ioctl {
> +	printf("Ioctling file %s with %d %d\n", name, cmd, arg)
> +}
> +
> +probe tty.init {
> +	printf("new tty with name %s from driver %s and module %s\n", driver_name, name, module)
> +}


-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)