This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] (Updated) trace tcp connections parameters


On 10/07/2009 02:27 PM, David J. Wilder wrote:
> Here is an update to the patch.
> 
> - Reduced possibility of array overflow by deleting the key map entries
>   when the state goes to TCP_CLOSE. Also, it now reports when a socket's
>   state goes to TCP_CLOSE.
> - Eliminated string copies in print_packet_info() and print_header().
> 
> Signed-off-by: David Wilder <dwilder@us.ibm.com>
> Signed-off-by: Varun Chandramohan <varunc@linux.vnet.ibm.com>

Acked-by: Josh Stone <jistone@redhat.com>

We're not at all formal with these tags, but it doesn't hurt. :)

> diff --git a/testsuite/systemtap.examples/network/tcp_trace.meta b/testsuite/systemtap.examples/network/tcp_trace.meta
> new file mode 100644
> index 0000000..2783c89
> --- /dev/null
> +++ b/testsuite/systemtap.examples/network/tcp_trace.meta
> @@ -0,0 +1,14 @@
> +title: Tcp connection tracing utility.
> +name: tcp_trace.stp
> +version: 1.0

Now 1.1?

> +author: varuncha@in.ibm.com wilder@us.ibm.com
> +keywords: network trace
> +subsystem: network
> +status: production
> +exit: user-controlled
> +output: timed

It's more of a trace output.

> diff --git a/testsuite/systemtap.examples/network/tcp_trace.stp b/testsuite/systemtap.examples/network/tcp_trace.stp
> new file mode 100644

Please make this executable in your commit.

Finally, please also run examples-index-gen.pl so this script will be
listed on the website.

Thanks,

Josh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]