This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH tracing/kprobes 4/7] tracing/kprobes: Add event profiling support
- From: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>
- To: Frederic Weisbecker <fweisbec at gmail dot com>
- Cc: Masami Hiramatsu <mhiramat at redhat dot com>, Steven Rostedt <rostedt at goodmis dot org>, Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, Andi Kleen <ak at linux dot intel dot com>, Christoph Hellwig <hch at infradead dot org>, "Frank Ch. Eigler" <fche at redhat dot com>, "H. Peter Anvin" <hpa at zytor dot com>, Jason Baron <jbaron at redhat dot com>, "K.Prasad" <prasad at linux dot vnet dot ibm dot com>, Lai Jiangshan <laijs at cn dot fujitsu dot com>, Li Zefan <lizf at cn dot fujitsu dot com>, Peter Zijlstra <peterz at infradead dot org>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, Tom Zanussi <tzanussi at gmail dot com>
- Date: Tue, 15 Sep 2009 10:22:27 +0530
- Subject: Re: [PATCH tracing/kprobes 4/7] tracing/kprobes: Add event profiling support
- References: <20090910235258.22412.29317.stgit@dhcp-100-2-132.bos.redhat.com> <20090910235329.22412.94731.stgit@dhcp-100-2-132.bos.redhat.com> <20090911031253.GD16396@nowhere> <4AAA7938.7070200@redhat.com> <20090914030244.GC14306@nowhere> <4AAE7540.9090009@redhat.com> <20090914185540.GD6045@nowhere> <4AAE9B41.3020905@redhat.com> <20090914210712.GH6045@nowhere>
- Reply-to: ananth at in dot ibm dot com
On Mon, Sep 14, 2009 at 11:07:13PM +0200, Frederic Weisbecker wrote:
> On Mon, Sep 14, 2009 at 03:36:33PM -0400, Masami Hiramatsu wrote:
> > Frederic Weisbecker wrote:
> >> On Mon, Sep 14, 2009 at 12:54:24PM -0400, Masami Hiramatsu wrote:
>
>
> >> There might be some of such factors that would force you to handle a
> >> lot of corner cases, things that you wouldn't need to worry about
> >> if you just had to maintain a simple rcu list of probes to call.
> >
> >
> > Anyway, I never see who are using post_handler:). I'm not sure why
> > it is needed...
>
>
> May be it's a legacy of code that was used by the past, in which case
> that could perhaps be cleaned up?
No, kprobe post_handlers are used in various places, especially for
debug purposes. It is part of the ABI and should be retained.
Ananth