This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip -v12 01/11] x86: instruction decoder API
- From: Sam Ravnborg <sam at ravnborg dot org>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, kvm <kvm at vger dot kernel dot org>, DLE <dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, "H. Peter Anvin" <hpa at zytor dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, Andi Kleen <ak at linux dot intel dot com>, Vegard Nossum <vegard dot nossum at gmail dot com>, Avi Kivity <avi at redhat dot com>, Przemys??awPawe??czyk <przemyslaw at pawelczyk dot it>
- Date: Thu, 16 Jul 2009 18:37:08 +0200
- Subject: Re: [PATCH -tip -v12 01/11] x86: instruction decoder API
- References: <20090716155652.6266.39970.stgit@localhost.localdomain> <20090716155700.6266.71011.stgit@localhost.localdomain>
>
> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
> new file mode 100644
> index 0000000..01e079a
> --- /dev/null
> +++ b/arch/x86/include/asm/inat.h
> @@ -0,0 +1,125 @@
> +#ifndef _ASM_INAT_INAT_H
> +#define _ASM_INAT_INAT_H
[With reference to comment on patch 2/12...]
You create inat.h here.
Could you investigave what is needed to factor out the stuff
needed from userspace so we can avoid the ugly havk where
you redefine types.h?
Maybe create a inat_types.h + inat.h as we do in other cases?
Same for the other files that requred the types.h hack.
Sam