This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 3/3] kprobes: cleanup: use list instead of hlist for insn_pages
- From: Ingo Molnar <mingo at elte dot hu>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>
- Date: Tue, 30 Jun 2009 23:25:12 +0200
- Subject: Re: [PATCH -tip 3/3] kprobes: cleanup: use list instead of hlist for insn_pages
- References: <20090630210757.17851.409.stgit@localhost.localdomain> <20090630210814.17851.64651.stgit@localhost.localdomain>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Use struct list instead of struct hlist for managing insn_pages,
> because insn_pages doesn't use hash table.
> struct kprobe_insn_page {
> - struct hlist_node hlist;
> + struct list_head list;
Hm, you know that this increases the size of kprobe_insn_page by 4/8
bytes, right?
hlists are not just used for hashes - but also when we want a more
compact / smaller list head.
How many kprobe_insn_page's can be allocated in the system,
maximally?
Ingo