This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix target_set tapset.


Josh Stone <jistone@redhat.com> writes:

> [...]
>> Death pid array is other solution, but clearing routine definitely
>> shouldn't be located in target_set_report. [...]
>
> Now I think you're just messing with me, but ok, I see that death arrays
> are making this overly complex.  We should just decide whether the
> records of dead pids should be kept around.

It can be useful to remember the dead ones sometimes, but perhaps not
for the purposes of this particular tapset, which is imagined to be
useful for controlling future probes.

If one wants the history too, a sibling tapset could be easily
authored, with a target_set_history_report() function triggering its
inclusion.  Or make it all moot with PR6525.

- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]