This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v6 1/5] x86: instruction decorder API
- From: Przemysław Pawełczyk <przemyslaw at pawelczyk dot it>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, kvm <kvm at vger dot kernel dot org>, DLE <dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, "H. Peter Anvin" <hpa at zytor dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, Andi Kleen <ak at linux dot intel dot com>, Vegard Nossum <vegard dot nossum at gmail dot com>, Avi Kivity <avi at redhat dot com>
- Date: Thu, 21 May 2009 00:01:24 +0200
- Subject: Re: [PATCH -tip v6 1/5] x86: instruction decorder API
- References: <20090520205758.25003.44632.stgit@localhost.localdomain> <20090520205805.25003.71314.stgit@localhost.localdomain>
On Wed, May 20, 2009 at 22:58, Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Changes from v5:
> - Use /usr/bin/env to find awk
This is fine, but not in the below case.
> --- /dev/null
> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk
> @@ -0,0 +1,314 @@
> +#!/usr/bin/env awk -f
Depending on multi-argument shebang is IMO bad. In shebang generally
(but not in all systems) everything after interpreter part is treated
as the first argument. Therefore executing your gen-insn-attr-x86.awk
is equivalent to:
/usr/bin/env 'awk -f' gen-insn-attr-x86.awk
which is obviously wrong.
--
Przemysław Pawełczyk