This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug runtime/10172] New: sdt.h on powerpc Error: junk at end of line: `0'
- From: "mjw at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: 20 May 2009 08:45:28 -0000
- Subject: [Bug runtime/10172] New: sdt.h on powerpc Error: junk at end of line: `0'
- Reply-to: sourceware-bugzilla at sourceware dot org
According to https://bugzilla.redhat.com/show_bug.cgi?id=489017#c13 sdt.h
stopped compiling on powerpc (ppc64). Error: junk at end of line: `0'
sounds familiar, that was most likely introduced in:
commit 1ce4311fbb8e3191449f919b784cea355a0cfe00
Author: Stan Cox <scox@redhat.com>
Date: Thu Apr 23 16:43:44 2009 -0400
Avoid a uprobe break setting problem by avoiding 'nop 0' on x86.
* sdt.h (STAP_NOP): New.
(STAP_PROBE): Use it.
I don't have a powerpc machine around. But I suspect it might be fixed by
something like:
diff --git a/includes/sys/sdt.h b/includes/sys/sdt.h
index 5899549..fd2c55f 100644
--- a/includes/sys/sdt.h
+++ b/includes/sys/sdt.h
@@ -59,7 +59,7 @@
#define STAP_UNINLINE_LABEL(label) \
__extension__ static volatile long labelval __attribute__ ((unused)) =
(long
-#if defined(__x86_64__) || defined(__i386__)
+#if defined(__x86_64__) || defined(__i386__) || defined(__powerpc__)
#define STAP_NOP "\tnop "
#else
#define STAP_NOP "\tnop 0 "
It might not be __powerpc__ though, it might only be __ppc64__.
Could someone with access to powerpc test this out? An easy test would be to see
whether 'make check RUNTESTFLAGS=sdt.exp' reports any failures.
A similar issue was mentioned in a recent test report thread on the mailinglist:
http://sourceware.org/ml/systemtap/2009-q2/msg00472.html
--
Summary: sdt.h on powerpc Error: junk at end of line: `0'
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
AssignedTo: systemtap at sources dot redhat dot com
ReportedBy: mjw at redhat dot com
CC: ananth at in dot ibm dot com,scox at redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=10172
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.