This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Correct misnamed and remove superfluous variables in syscalls.stp.
- From: Przemysław Pawełczyk <przemyslaw at pawelczyk dot it>
- To: Josh Stone <jistone at redhat dot com>
- Cc: systemtap at sourceware dot org
- Date: Tue, 19 May 2009 02:39:47 +0200
- Subject: Re: [PATCH] Correct misnamed and remove superfluous variables in syscalls.stp.
- References: <1242689780.410095.4911@debian> <4A11FA7A.9010403@redhat.com>
On Tue, May 19, 2009 at 02:16, Josh Stone <jistone@redhat.com> wrote:
> On 05/18/2009 04:12 PM, Przemyslaw Pawelczyk wrote:
>> In syscall.(faccess|fchmod|fchown|link|mknod)at probe points:
>> - Rename variables accordingly to argument names used in man pages.
>
> This much is good.
I'll resend the patch in 10 hours.
>> - Remove string-formatted integer variables.
>
> I don't agree with this part though, because those string variables are
> providing a non-trivial conversion using undocumented functions
> (prefixed with '_'). ?I think that's valuable to have, and it doesn't
> hurt anything for scripts that don't use them.
You're right and as a consequence of this there is a need for
"reversed" patch, that provides string-formatted integer variables in
other probes..
> Josh
Regards.
--
Przemysław Pawełczyk