This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Correct misnamed and remove superfluous variables in syscalls.stp.


On 05/18/2009 04:12 PM, Przemyslaw Pawelczyk wrote:
> In syscall.(faccess|fchmod|fchown|link|mknod)at probe points:
> - Rename variables accordingly to argument names used in man pages.

This much is good.

> - Remove string-formatted integer variables.

I don't agree with this part though, because those string variables are
providing a non-trivial conversion using undocumented functions
(prefixed with '_').  I think that's valuable to have, and it doesn't
hurt anything for scripts that don't use them.

Josh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]